incubator-bigtop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Mahé (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (BIGTOP-524) Add tests to verify that our init scripts conform to the LSB specification
Date Thu, 12 Apr 2012 06:38:29 GMT

    [ https://issues.apache.org/jira/browse/BIGTOP-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252242#comment-13252242
] 

Bruno Mahé commented on BIGTOP-524:
-----------------------------------

Agreed. We should always run them.
But still, the test cases you are pointing too is missing quite a few cases
                
> Add tests to verify that our init scripts conform to the LSB specification
> --------------------------------------------------------------------------
>
>                 Key: BIGTOP-524
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-524
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Bruno Mahé
>
> I recently submitted BIGTOP-505 and BIGTOP-506, but we should proactively verify all
our init scripts follow the LSB specification.
> This would avoid some issues where for instance third party tools get confused by the
return code of some action.
> So we should add tests to ensure that init scripts follow http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> Here are some cased to be checked (extract from the spec linked above):
> {noformat}
> For all other init-script actions, the init script shall return an exit status of zero
if the action was successful. Otherwise, the exit status shall be non-zero, as defined below.
In addition to straightforward success, the following situations are also to be considered
successful:
>     restarting a service (instead of reloading it) with the force-reload argument
>     running start on a service already running
>     running stop on a service already stopped or not running
>     running restart on a service already stopped or not running
>     running try-restart on a service already stopped or not running
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message