incubator-bigtop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Mahé (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (BIGTOP-186) whirr package still has some log files packaged
Date Fri, 13 Apr 2012 01:41:18 GMT

    [ https://issues.apache.org/jira/browse/BIGTOP-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253044#comment-13253044
] 

Bruno Mahé commented on BIGTOP-186:
-----------------------------------

Sorry but your patch doesn't match the current content for whirr.
Here is a quick package review from latest build in trunk:

* All the files are 755. Only executable files should be 755

{noformat}
rwxr-xr-x    1 root    root                      274 Feb 23 14:39 /usr/lib/whirr/BUILD.txt
-rwxr-xr-x    1 root    root                    24006 Feb 23 14:44 /usr/lib/whirr/CHANGES.txt
-rwxr-xr-x    1 root    root                    37114 Feb 23 14:39 /usr/lib/whirr/LICENSE.txt
-rwxr-xr-x    1 root    root                      406 Feb 23 14:39 /usr/lib/whirr/NOTICE.txt
-rwxr-xr-x    1 root    root                     1854 Feb 23 14:39 /usr/lib/whirr/README.txt
{noformat}

=> These files should be 644 and in %{docdir}

{noformat}/usr/lib/whirr/build-tools{noformat}
=> Should not exist

{noformat}
drwxr-xr-x    2 root    root                        0 Feb 23 14:39 /usr/lib/whirr/cli/src
drwxr-xr-x    2 root    root                        0 Feb 23 14:39 /usr/lib/whirr/core/src
{noformat}
=> Should not exist at all. No need to bundle the source

{noformat}-rwxr-xr-x    1 root    root                     5775 Feb 23 14:48 /usr/lib/whirr/cli/pom.xml{noformat}
=> Delete all pom.xml

{noformat}/usr/lib/whirr/conf{noformat}
=> Should be a symlink to /etc/whirr/conf if needed. If not needed we should just have
/etc/whirr/conf


{noformat}
drwxr-xr-x    2 root    root                        0 Apr  9 17:54 /usr/lib/whirr/docs
lrwxr-xr-x    1 root    root                       30 Apr  9 17:54 /usr/lib/whirr/docs/whirr-0.7.1.13
-> //usr/share/doc/whirr-0.7.1.13
{noformat}
=> Seems fishy to me


{noformat}/usr/lib/whirr/examples{noformat}
=> Probably better with the docs


                
> whirr package still has some log files packaged
> -----------------------------------------------
>
>                 Key: BIGTOP-186
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-186
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Peter Linnell
>            Assignee: Peter Linnell
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: BIGTOP-186.patch
>
>
> This is actually an upstream problem, but this is to track and perhaps offer a fix for
upstream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message