incubator-bigtop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Mahé (JIRA) <j...@apache.org>
Subject [jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled
Date Wed, 21 Sep 2011 18:43:09 GMT

    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109766#comment-13109766
] 

Bruno Mahé commented on BIGTOP-102:
-----------------------------------

We should really start using revbiewboard for big patches at least.

+  force-reload|condrestart|try-restart)
+        is_oozie_alive
+        if [ ${STATUS} -eq 0 ] ; then
+          stop_oozie
+          start_oozie
+        fi
+        exit 0
+        ;;

=> Any reason to exit 0, but instead of reusing the status code of start_oozie (or the
status of stop_oozie if it failed)




+	sed -e 's#@FLUME_DAEMON@#$@#g' $< > debian/flume-$@.init

=> Is creating/modifying files directly in debian/ ok in debian land? Or should we instread
do that directly whet it is supposed to be installed?


+# Short-Description:    Cloudera Flume @FLUME_DAEMON@
=> It's Apache now :)


Other than that, seems reasonable to me

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the
following behavior:
>     * on installation they start (or don't start) the services depending on the defaults
for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message