Return-Path: X-Original-To: apmail-incubator-bigtop-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-bigtop-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4AD89916 for ; Sun, 24 Jun 2012 20:59:27 +0000 (UTC) Received: (qmail 8442 invoked by uid 500); 24 Jun 2012 20:59:27 -0000 Delivered-To: apmail-incubator-bigtop-commits-archive@incubator.apache.org Received: (qmail 8389 invoked by uid 500); 24 Jun 2012 20:59:27 -0000 Mailing-List: contact bigtop-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bigtop-dev@incubator.apache.org Delivered-To: mailing list bigtop-commits@incubator.apache.org Received: (qmail 8381 invoked by uid 99); 24 Jun 2012 20:59:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jun 2012 20:59:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jun 2012 20:59:25 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B9B302388847; Sun, 24 Jun 2012 20:59:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1353330 - in /incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke: PackageTestCommon.groovy TestPackagesBasics.groovy Date: Sun, 24 Jun 2012 20:59:04 -0000 To: bigtop-commits@incubator.apache.org From: rvs@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120624205904.B9B302388847@eris.apache.org> Author: rvs Date: Sun Jun 24 20:59:03 2012 New Revision: 1353330 URL: http://svn.apache.org/viewvc?rev=1353330&view=rev Log: BIGTOP-649. PackageTestCommon.checkRemoval() is broken (Andrew Bayer via rvs) Modified: incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy Modified: incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy URL: http://svn.apache.org/viewvc/incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy?rev=1353330&r1=1353329&r2=1353330&view=diff ============================================================================== --- incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy (original) +++ incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy Sun Jun 24 20:59:03 2012 @@ -480,15 +480,6 @@ class PackageTestCommon { } } - public void checkRemoval() { - checkThat("package $name failed to be removed", - pkg.remove(), equalTo(0)); - checkThat("package $name is NOT expected to remain installed after removal", - pm.isInstalled(pkg), equalTo(false)); - - checkPackageFilesGotRemoved(getMap(golden.content)); - } - static public boolean isUpgrade() { return System.getProperty("cdh.prev.repo.version", "") != ""; } Modified: incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy URL: http://svn.apache.org/viewvc/incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy?rev=1353330&r1=1353329&r2=1353330&view=diff ============================================================================== --- incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy (original) +++ incubator/bigtop/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy Sun Jun 24 20:59:03 2012 @@ -257,4 +257,14 @@ class TestPackagesBasics extends Package return res; } + + public void checkRemoval() { + checkThat("package $name failed to be removed", + pkg.remove(), equalTo(0)); + checkThat("package $name is NOT expected to remain installed after removal", + pm.isInstalled(pkg), equalTo(false)); + + checkPackageFilesGotRemoved(getMap(golden.content)); + } + }