Return-Path: Delivered-To: apmail-incubator-aries-commits-archive@minotaur.apache.org Received: (qmail 33454 invoked from network); 18 Jun 2010 17:30:33 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 Jun 2010 17:30:33 -0000 Received: (qmail 49654 invoked by uid 500); 18 Jun 2010 17:30:33 -0000 Delivered-To: apmail-incubator-aries-commits-archive@incubator.apache.org Received: (qmail 49572 invoked by uid 500); 18 Jun 2010 17:30:32 -0000 Mailing-List: contact aries-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: aries-dev@incubator.apache.org Delivered-To: mailing list aries-commits@incubator.apache.org Received: (qmail 49564 invoked by uid 99); 18 Jun 2010 17:30:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jun 2010 17:30:32 +0000 X-ASF-Spam-Status: No, hits=-1673.5 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jun 2010 17:30:32 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id AE92B2388993; Fri, 18 Jun 2010 17:29:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r956055 - /incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js Date: Fri, 18 Jun 2010 17:29:46 -0000 To: aries-commits@incubator.apache.org From: zoe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100618172946.AE92B2388993@eris.apache.org> Author: zoe Date: Fri Jun 18 17:29:46 2010 New Revision: 956055 URL: http://svn.apache.org/viewvc?rev=956055&view=rev Log: ARIES-319 Modifying order in removeSelf() so that we do a bit less work Modified: incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js Modified: incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js URL: http://svn.apache.org/viewvc/incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js?rev=956055&r1=956054&r2=956055&view=diff ============================================================================== --- incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js (original) +++ incubator/aries/trunk/samples/goat/goat-web/src/main/resources/web/goat/Component.js Fri Jun 18 17:29:46 2010 @@ -163,13 +163,8 @@ updateProperties : function(props) { // console.log("Properties processed."); }, removeSelf : function() { - //Remove this component and all the relationship elements attached to it. - //This one is subscribed to by RelationshipElement - dojo.publish("goat.component.delete." + this.id, [ this ]); - - //This one is subscribed to by ComponentStatusGrid - dojo.publish("goat.component.delete", [ this ]); + //Remove this component and all the relationship elements attached to it. this.surface.remove(this.group); //Now we remove all other the elements for (var type in this.elements) { @@ -178,6 +173,12 @@ removeSelf : function() { } this.relationshipManager.removeSelf(); delete this.RelationshipManager; + + //This one is subscribed to by RelationshipElement + dojo.publish("goat.component.delete." + this.id, [ this ]); + + //This one is subscribed to by ComponentStatusGrid + dojo.publish("goat.component.delete", [ this ]); }, initGfx : function() { this.group = this.surface.createGroup();