incubator-any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michele Mostarda <michele.mosta...@gmail.com>
Subject Re: Any23 Modularization
Date Fri, 10 Aug 2012 09:59:10 GMT
On 10 August 2012 06:27, Peter Ansell <ansell.peter@gmail.com> wrote:

> Hi all,
>
> I checked over the test-resource-jar patch again this morning and it
> still looked right, and all of the tests still pass, so I committed it
> to subversion.
>
+1

>
> I have since ported a patch across from my previous patches to create
> an apache-any23-api.jar file that contains the basic information
> needed to split up the rest of the core module. [2]
>
+1

>
> I also discovered that the URL at [1] was comparing against the
> apache-git:trunk (at GitHub, which is not updated that regularly,
> ~once a day it seems). Using ansell:trunk in the GitHub compare URL
> compares against whatever I have last downloaded from git.apache.org.
>
> If someone wants to review it and comment here or on ANY23-114 in the
> next 48 hours I will commit it to subversion with any necessary
> changes after the weekend. (Assuming Jira is working, which it doesn't
> seem to be about 50 percent of the time right now). I have been
> working personally using this api module (and the test-resource-jar
> module) for the past 3 months (api module first committed on May 10),
> so I doubt there is anything majorly wrong with the patch, but any
> reviews are always helpful.
>

Jira is down now, will try later in the afternoon :(

>
> Cheers,
>
> Peter
>

Cheers.
Mic

>
> [2]
> https://github.com/ansell/any23/compare/ansell:trunk...ansell:api-module
>
> On 9 August 2012 12:47, Peter Ansell <ansell.peter@gmail.com> wrote:
> > Hi,
> >
> > I have a patch on GitHub [1] available to move the test resources out
> > into their own module and modify the tests to work by copying the
> > resources out to temporary files that are all cleaned up by JUnit
> > after each test.
> >
> > The Apache Jira does not appear to be available right now, but this
> > corresponds to ANY23-103 that I filed in June.
> >
> > Could someone review that patch for me as it is quite large and I may
> > have added something that was not necessary.
> >
> > This patch is the precursor to the modularisation process, as without
> > it the tests cannot be moved out of the core module.
> >
> > Thanks,
> >
> > Peter
> >
> > [1] https://github.com/ansell/any23/compare/trunk...test-resource-jar
> >
> > On 7 August 2012 21:16, Lewis John Mcgibbney <lewis.mcgibbney@gmail.com>
> wrote:
> >> Hi Simo,
> >>
> >> I also provide my full backing for this. I think Peter's suggestion
> >> here was an excellent injection and I would back the restructuring
> >> effort entirely as well.
> >> Lewis
> >>
> >> On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
> >> <simonetripodi@apache.org> wrote:
> >>> Hi Peter,
> >>>
> >>>> I am looking in the short term to restructure the Maven modules inside
> >>>> of Any23 so that the different facets can be reused, tested and
> >>>> maintained easily, particularly with a view to using the RDF related
> >>>> Tika enhancements that the Any23 MIME Detector provides. I made these
> >>>> changes a few months ago in my GitHub fork [2], so feel free to review
> >>>> them closely to suggest enhancements before I actually start. I am not
> >>>> sure when I will next have time to clean up the patches. The first
> >>>> step that I want to take is to split out the test resources into a
> >>>> single module and switch from "src/test/resources/*" File based access
> >>>> in tests to using this.getClass().getResourceAsStream("*"). I have
> >>>> implemented those changes in my git repository but the patches may
> >>>> need cleaning up as I have not gone back to review them yet. After
> >>>> that is done, it will be relatively simple to split out both the
> >>>> packages and tests into separate modules.
> >>>
> >>> You have my full support on this step, I would be more than glad to
> >>> provide feedbacks - feel free to ping me when/if needed!
> >>>
> >>> I also think we could take advantage from this work to get rid of many
> >>> builders-of-factories and switching the Any23 runtime environment to
> >>> something more standard-ish, i.e. JSR-330
> >>> <http://www.jcp.org/en/jsr/detail?id=330>
> >>>
> >>> Have a nice day, all the best!
> >>> -Simo
> >>>
> >>> http://people.apache.org/~simonetripodi/
> >>> http://simonetripodi.livejournal.com/
> >>> http://twitter.com/simonetripodi
> >>> http://www.99soft.org/
> >>
> >>
> >>
> >> --
> >> Lewis
>



-- 
Michele Mostarda
Senior Software Engineer
skype: michele.mostarda
twitter: micmos
mail: me@michelemostarda.com
site : http://www.michelemostarda.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message