incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-3672) Add Support to AmbariManagementController to derive configs from Config groups
Date Thu, 07 Nov 2013 14:53:17 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816013#comment-13816013
] 

Nate Cole commented on AMBARI-3672:
-----------------------------------

* The constant "tag" is used in various places and is defined twice - in AmbariManagementControllerImpl
and ConfigHelper.  There should be only one.
* (Minor) - ExecutionCommandWrapper, around line 75 - you create a new instance of ConfigHelper
within the loop, but it probably doesn't need to be (it's not singleton either).
* ConfigHelper - maybe this needs a new JIRA: the use of applyCustomConfig(...) and getMergedConfig(...)
are suspicious.  The calls to these seem pretty specific, so they could be handled in ConfigHelper
itself and make things a bit easier to troubleshoot.

> Add Support to AmbariManagementController to derive configs from Config groups
> ------------------------------------------------------------------------------
>
>                 Key: AMBARI-3672
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3672
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>    Affects Versions: 1.4.2
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 1.4.3
>
>         Attachments: AMBARI-3672.patch
>
>
> Application of the configurations boils down to figuring out the configs for a Service
Host Component when a Task is to be created for the host. Rules to apply configuration changes:
> - Apply cluster desired configs
> - Get all the config groups for the host
> - Apply the overrides per config type.  (In future this can go through config groups
for service then component and host component in that order)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message