incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Wagle (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-3317) Refactor AmbariMetaInfo to use JAXB instead of DOM
Date Mon, 23 Sep 2013 22:20:04 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775719#comment-13775719
] 

Siddharth Wagle commented on AMBARI-3317:
-----------------------------------------

Patch looks good, minor comments below:

1. Is this comment valid?
+  // two classes define the top-level element "metainfo", so we need 2 contexts.

2. Could we add a negative unit test case for the testing a JAXBException?

Overall, LGTM +1



                
> Refactor AmbariMetaInfo to use JAXB instead of DOM
> --------------------------------------------------
>
>                 Key: AMBARI-3317
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3317
>             Project: Ambari
>          Issue Type: Task
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>         Attachments: AMBARI-3317.patch
>
>
> Several changes will require easier parsing of various stack files.  This task will stop
using DOM parsing and let JAXB do the work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message