incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-2762) Additional YARN metrics required in service status call
Date Tue, 30 Jul 2013 13:07:50 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723831#comment-13723831
] 

Nate Cole commented on AMBARI-2762:
-----------------------------------

Though only one time actually added in the diff, the following pattern shows 3 times:

{code}propertyId.matches(".*\\$\\d+.*"){code}

It looks like this pattern will be called several times, which will have to compile a new
pattern.  Maybe we should define a static {{Pattern}} and a helper method like you did for
{{AbstractPropertyProvider}} (except, this one is used also in {{BaseProvider}}).  Either
that, that pattern string should be statically defined in case we change it in the future
(for other than just $1, $2 etc) and we miss a change.

Everything else looks good.
                
> Additional YARN metrics required in service status call
> -------------------------------------------------------
>
>                 Key: AMBARI-2762
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2762
>             Project: Ambari
>          Issue Type: Task
>            Reporter: Tom Beerbower
>            Assignee: Tom Beerbower
>         Attachments: AMBARI-2762.patch
>
>
> When client calls /api/v1/clusters/vm/services?fields=components/host_components/metrics/yarn/Queue,
we need following additional information:
>     Queues defined (hierarchy also if possible)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message