incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AMBARI-2590) JS Error when delete a widget after sorting it on remove/edit sign
Date Tue, 09 Jul 2013 01:38:46 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702764#comment-13702764
] 

Yusaku Sako edited comment on AMBARI-2590 at 7/9/13 1:37 AM:
-------------------------------------------------------------

Thanks [~xiwang0309].
Just a minor nit, but since reformatting afterwards makes it difficult to review/may create
unnecessary clean JIRAs in the future... let's follow the standard coding convention.
Specifically:
{noformat}
* Variable names should be camel-cased ("obj_class" should be "objClass").
* "if(App.testMode) {" should be "if (App.testMode) {".
* "}else{" should be "} else {".
{noformat}

Please review https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari
and  http://javascript.crockford.com/code.html
                
      was (Author: u39kun):
    Thanks [~xiwang0309].
Just a minor nit, but since reformatting afterwards makes it difficult to review/may create
unnecessary clean JIRAs in the future... let's follow the standard coding convention.
Specifically:
* Variable names should be camel-cased ("obj_class" should be "objClass").
* "if(App.testMode) {" should be "if (App.testMode) {".
* "}else{" should be "} else {".

Please review https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari
and  http://javascript.crockford.com/code.html
                  
> JS Error when delete a widget after sorting it on remove/edit sign
> ------------------------------------------------------------------
>
>                 Key: AMBARI-2590
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2590
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Xi Wang
>            Assignee: Xi Wang
>         Attachments: AMBARI-2590.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message