incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-2576) Security CSV does not download on Safari / IE 9
Date Mon, 08 Jul 2013 19:45:48 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702330#comment-13702330
] 

Yusaku Sako commented on AMBARI-2576:
-------------------------------------

[~ababiichuk], doDownloadCsv method has moved to admin/security/add/step3.js.  Please update
the patch.
Also, please follow the coding conventions per https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari.

{code}
    if($.browser.msie && $.browser.version < 10) {
        this.OpenInfoInNewTab();
    }
    else {
       var blob = new Blob([this.buildCvsContent()], {type: "text/plain;charset=utf-8;"});
       saveAs(blob, "host-principal-keytab-list.csv");
    }
{code}

Specifically:
* need a space after "if"
* "} else {" on all one line
* two spaces rather than 4 spaces for indentation
* function names should begin with a lower-case letter
                
> Security CSV does not download on Safari / IE 9
> -----------------------------------------------
>
>                 Key: AMBARI-2576
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2576
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.2.5
>         Environment: Safari, Mac OSX
>            Reporter: Andrii Babiichuk
>            Assignee: Andrii Babiichuk
>             Fix For: 1.2.5
>
>         Attachments: AMBARI-2576-1.patch, AMBARI-2576.patch
>
>
> Safari doesn't download security csv file. To reproduce go to Admin security page; Enable
security wizard; Click "Download CSV".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message