incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-1777) Support Delete host API in Ambari to be able to delete a host from a cluster.
Date Mon, 15 Jul 2013 20:38:49 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708949#comment-13708949
] 

Sumit Mohanty commented on AMBARI-1777:
---------------------------------------

Mostly nits, LGTM, +1.

Remove line - 
+//    throw new AmbariException("Delete hosts not supported");

What will happen if a DELETE is invoked for a host that does not exist under api/v1/hosts?
Looks like it may get added into the okToRemove list and clusters.deleteHost will get called.
It might be OK as the method can handle this scenario but wanted to bring it up.

+      if (!component.isClientComponent() &&
So we now allow removal of client components. In that case, should we modify the error text
as well? Something like - _To remove master or slave components they must be ..._. We can
also modify the comment in the code.

+  public void removeAllHost(long clusterId, String hostName) {
Should we rename it to removeHost (no All)




                
> Support Delete host API in Ambari to be able to delete a host from a cluster.
> -----------------------------------------------------------------------------
>
>                 Key: AMBARI-1777
>                 URL: https://issues.apache.org/jira/browse/AMBARI-1777
>             Project: Ambari
>          Issue Type: New Feature
>    Affects Versions: 1.3.0
>            Reporter: Mahadev konar
>            Assignee: Nate Cole
>             Fix For: 1.3.1
>
>         Attachments: AMBARI-1777.patch
>
>
> Support Delete host API in Ambari to be able to delete a host from a cluster. Also it
would be best if the delete would only work if all the compoenents were in MAINTENANCE state,
else it should fail to delete the node.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message