Return-Path: X-Original-To: apmail-incubator-ambari-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ambari-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8CCD610A97 for ; Wed, 19 Jun 2013 18:04:23 +0000 (UTC) Received: (qmail 70369 invoked by uid 500); 19 Jun 2013 18:04:22 -0000 Delivered-To: apmail-incubator-ambari-dev-archive@incubator.apache.org Received: (qmail 70174 invoked by uid 500); 19 Jun 2013 18:04:22 -0000 Mailing-List: contact ambari-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ambari-dev@incubator.apache.org Delivered-To: mailing list ambari-dev@incubator.apache.org Received: (qmail 70119 invoked by uid 99); 19 Jun 2013 18:04:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2013 18:04:21 +0000 Date: Wed, 19 Jun 2013 18:04:21 +0000 (UTC) From: "Jaimin D Jetly (JIRA)" To: ambari-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-2428) Global properties retrieved from server and absent on ui metadata doesn't allow saving configurations. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688228#comment-13688228 ] Jaimin D Jetly commented on AMBARI-2428: ---------------------------------------- Patch integrated to trunk. > Global properties retrieved from server and absent on ui metadata doesn't allow saving configurations. > ------------------------------------------------------------------------------------------------------ > > Key: AMBARI-2428 > URL: https://issues.apache.org/jira/browse/AMBARI-2428 > Project: Ambari > Issue Type: Bug > Components: client > Affects Versions: 1.2.5 > Reporter: Jaimin D Jetly > Assignee: Jaimin D Jetly > Fix For: 1.2.5 > > Attachments: AMBARI-2428.patch > > > We do errorCount on properties present in in-memory data-structure and have isVisible attribute set to true. > If there are properties retrieved from server global configurations and not present on ui global metadata, We don't set it's isVisible flag explicitly to false and so they are a part of the in-memory data-structure with isVisible attribute to true. > Such condition could arise When global configuration on the server is changed via API creating a new property whose value is invalid according to UI validations. > OR > Post-install removing a property from UI metadata whose isVisible attribute was false and had invalid value . This might happen during upgrades. > As a part of solution We should set isVisible attribute of such properties to false. Global properties need to be in UI metadata with isVisible flag set to true to be displayed. We are not showing these properties anyways as they are not in the metadata and shouldn't do errorCount on it as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira