incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-2463) Missing property and redundant properties in setup ldap flow
Date Fri, 21 Jun 2013 22:10:20 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690795#comment-13690795
] 

Sumit Mohanty commented on AMBARI-2463:
---------------------------------------

=================================
-def get_value_from_properties(properties, key):
+def get_value_from_properties(properties, key, default=""):
   try:
-    value = properties[key]
-  except KeyError:
-    return ""
+    value = properties.get_property(key)
+    if not value:
+      value = default
+  except:
+    return default
   return value
=======
If there is any error, this will still return default value. Is that OK? What if the properties
file does not exist? Should we return default only if the property is missing in the properties
file?

==================================
+  ldap_property_list_opt = [ "authentication.ldap.managerDn",
+                             LDAP_MGR_PASSWORD_PROPERTY ]
=======
Should we use LDAP_MGR_USERNAME_PROPERTY instead of "authentication.ldap.managerDn"



                
> Missing property and redundant properties in setup ldap flow
> ------------------------------------------------------------
>
>                 Key: AMBARI-2463
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2463
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>         Attachments: AMBARI-2463.patch
>
>
> 1) We should not be prompting for (or saving) anything related to the group-role mapping
(i.e. the authorization.* stuff) since feature not enabled.
> 2) Some properties are required and we shouldn't allow people to skip. Otherwise, LDAP
won't work at all. So we need to handle that some are required and not allow them to just
leave it blank.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message