incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Wagle (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-2365) Use lock or concurrent hash map to store response and responseId for heartbeat
Date Wed, 12 Jun 2013 17:37:20 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681423#comment-13681423
] 

Siddharth Wagle commented on AMBARI-2365:
-----------------------------------------

+1 LGTM
                
> Use lock or concurrent hash map to store response and responseId for heartbeat
> ------------------------------------------------------------------------------
>
>                 Key: AMBARI-2365
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2365
>             Project: Ambari
>          Issue Type: Bug
>          Components: controller
>    Affects Versions: 1.2.5
>            Reporter: Sumit Mohanty
>            Assignee: Sumit Mohanty
>             Fix For: 1.2.5
>
>         Attachments: AMBARI-2365.patch
>
>
> {code}
> private Map<String, Long> hostResponseIds = new HashMap<String, Long>();
>   private Map<String, HeartBeatResponse> hostResponses = new HashMap<String,
HeartBeatResponse>();
> {code}
> Noticed spurious re-registrations because the responseId from agent was not recognized
by the server. It seems to be due to lack of synchronization around the above fields considering
multiple threads may modify the map.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message