incubator-ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-581) special characters in hosts files created on some common windows editors causes issues
Date Wed, 27 Jun 2012 22:46:43 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402633#comment-13402633
] 

Hitesh Shah commented on AMBARI-581:
------------------------------------

Please provide patches from top of the branch and not from top of the repo.

Fix indentation to use spaces and not tabs. Follow same indentation level in patch as rest
of code. I believe all code currently uses 2 spaces. 

The patch has "^M" control-chars in it. 

Any reason why this code could not be implemented in the readHostsFile function? 
                
> special characters in hosts files created on some common windows editors causes issues
> --------------------------------------------------------------------------------------
>
>                 Key: AMBARI-581
>                 URL: https://issues.apache.org/jira/browse/AMBARI-581
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Jaimin D Jetly
>            Assignee: Jaimin D Jetly
>         Attachments: AMBARI-581.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message