Return-Path: X-Original-To: apmail-incubator-ambari-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-ambari-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5A44DF89 for ; Sat, 2 Feb 2013 02:23:58 +0000 (UTC) Received: (qmail 34986 invoked by uid 500); 2 Feb 2013 02:23:58 -0000 Delivered-To: apmail-incubator-ambari-commits-archive@incubator.apache.org Received: (qmail 34966 invoked by uid 500); 2 Feb 2013 02:23:58 -0000 Mailing-List: contact ambari-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ambari-dev@incubator.apache.org Delivered-To: mailing list ambari-commits@incubator.apache.org Received: (qmail 34959 invoked by uid 99); 2 Feb 2013 02:23:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Feb 2013 02:23:58 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Feb 2013 02:23:56 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 7BA4E23888E7; Sat, 2 Feb 2013 02:23:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1441687 - in /incubator/ambari/trunk: CHANGES.txt ambari-web/app/controllers/wizard/step9_controller.js Date: Sat, 02 Feb 2013 02:23:36 -0000 To: ambari-commits@incubator.apache.org From: yusaku@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130202022336.7BA4E23888E7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: yusaku Date: Sat Feb 2 02:23:36 2013 New Revision: 1441687 URL: http://svn.apache.org/viewvc?rev=1441687&view=rev Log: AMBARI-1334. Show hosts that have failed install tasks as red to allow the user to easily identify source of failure. (yusaku) Modified: incubator/ambari/trunk/CHANGES.txt incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js Modified: incubator/ambari/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/CHANGES.txt?rev=1441687&r1=1441686&r2=1441687&view=diff ============================================================================== --- incubator/ambari/trunk/CHANGES.txt (original) +++ incubator/ambari/trunk/CHANGES.txt Sat Feb 2 02:23:36 2013 @@ -38,6 +38,9 @@ Trunk (unreleased changes): IMPROVEMENTS + AMBARI-1334. Show hosts that have failed install tasks as "red" to allow the user + to easily identify source of failure. (yusaku) + AMBARI-1333. Add username validation for Ambari local users. (yusaku) AMBARI-1329. Adjust job browser column sizing. (yusaku) Modified: incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js?rev=1441687&r1=1441686&r2=1441687&view=diff ============================================================================== --- incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js (original) +++ incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js Sat Feb 2 02:23:36 2013 @@ -338,7 +338,7 @@ App.WizardStep9Controller = Em.Controlle if (actions.someProperty('Tasks.status', 'FAILED') || actions.someProperty('Tasks.status', 'ABORTED') || actions.someProperty('Tasks.status', 'TIMEDOUT')) { contentHost.set('status', 'warning'); } - if (this.get('content.cluster.status') === 'PENDING' && this.isMasterFailed(actions)) { + if (this.get('content.cluster.status') === 'PENDING' && actions.someProperty('Tasks.status', 'FAILED')) { contentHost.set('status', 'failed'); } }, @@ -405,19 +405,6 @@ App.WizardStep9Controller = Em.Controlle return failed; }, - //return true if there is at least one FAILED task of master component install - isMasterFailed: function(polledData) { - var result = false; - polledData.filterProperty('Tasks.status', 'FAILED').mapProperty('Tasks.role').forEach ( - function (task) { - if (!['DATANODE', 'TASKTRACKER', 'HBASE_REGIONSERVER', 'GANGLIA_MONITOR'].contains(task)) { - result = true; - } - } - ); - return result; - }, - // makes a state transition // PENDING -> INSTALLED // PENDING -> INSTALL FAILED