incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #7130 Blob.next_commit and prev_commit should be removed
Date Wed, 05 Feb 2014 21:05:30 GMT
- **status**: code-review --> closed


** [tickets:#7130] Blob.next_commit and prev_commit should be removed**

**Status:** closed
**Labels:** performance 
**Created:** Tue Feb 04, 2014 06:33 PM UTC by Cory Johns
**Last Updated:** Wed Feb 05, 2014 08:47 PM UTC
**Owner:** Cory Johns

`Blob.context()` (which is called when on the file view page) calls `Blob.next_commit` but
the result is not used.  `Blob.next_commit` walks down the commit tree to find the next commit
that modified the file, which for rarely modified files can result in a lot of useless work.

`Blob.prev_commit` is more efficient, but is also not used.

Remove both, as well as associated tests in `Allura/allura/tests/unit/`, and ensure
there is no visible impact to the UI of the file view page.


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message