incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cory Johns" <masterbunn...@users.sf.net>
Subject [allura:tickets] #7130 Blob.next_commit and prev_commit should be removed
Date Tue, 04 Feb 2014 20:02:00 GMT
- **status**: in-progress --> code-review
- **Size**:  --> 1



---

** [tickets:#7130] Blob.next_commit and prev_commit should be removed**

**Status:** code-review
**Labels:** performance 
**Created:** Tue Feb 04, 2014 06:33 PM UTC by Cory Johns
**Last Updated:** Tue Feb 04, 2014 06:36 PM UTC
**Owner:** Cory Johns

`Blob.context()` (which is called when on the file view page) calls `Blob.next_commit` but
the result is not used.  `Blob.next_commit` walks down the commit tree to find the next commit
that modified the file, which for rarely modified files can result in a lot of useless work.

`Blob.prev_commit` is more efficient, but is also not used.

Remove both, as well as associated tests in `Allura/allura/tests/unit/test_repo.py`, and ensure
there is no visible impact to the UI of the file view page.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message