incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cory Johns" <masterbunn...@users.sf.net>
Subject [allura:tickets] #7005 allura.tasks.repo_tasks.clone clobbers Project record
Date Wed, 08 Jan 2014 23:56:37 GMT
`allura:cj/7005`
`forgehg:cj/7005`

I tried and failed to come up with a way to create a test case for this; since the tests use
MIM, there's no way to do an "out-of-band" update to ensure it doesn't get overwritten.

###### To QA:

Add a breakpoint to, e.g., `forgegit.model.git_repo.GitImplementation.clone_from` then start
a clone of a repo (or just clone a large repo w/o a breakpoint).  While it's processing, update
something on the project metadata, such as the summary.

May want to try with the breakpoint in a few different points in the code (start of the task,
`clone_from`, `repo_refresh`, end of task).


---

** [tickets:#7005] allura.tasks.repo_tasks.clone clobbers Project record**

**Status:** code-review
**Created:** Wed Dec 18, 2013 04:30 PM UTC by Dave Brondsema
**Last Updated:** Tue Jan 07, 2014 11:07 PM UTC
**Owner:** Cory Johns

It appears that the allura.tasks.repo_tasks.clone task flushes the Project record at the end,
and since that task can take a very long time, any updates (e.g. to project description) get
lost when it saves the old project document back to mongo.

I haven't duplicated this in development, but here's what happened on sourceforge:

* Google Code import was used; `import_project_info` task ran at 2013/12/17 04:54:38 https://sourceforge.net/nf/admin/task_manager/view/52afd90dc4314373398546ad
* Repo clone started at 2013/12/17 04:54:39 https://sourceforge.net/nf/admin/task_manager/view/52afd90e34309d0fdc251462
* short description was manually set, at 2013-12-17 06:07:16 (per Audit Log)
* Repo clone finished at 2013/12/17 07:32:09 and currently the short description is empty.

I didn't find any other tasks with the specific project_id that completed after 06:07:16,
so I believe it's the repo clone task at fault.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message