Return-Path: X-Original-To: apmail-incubator-allura-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-allura-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6D6B10926 for ; Mon, 9 Dec 2013 20:42:04 +0000 (UTC) Received: (qmail 89848 invoked by uid 500); 9 Dec 2013 20:42:04 -0000 Delivered-To: apmail-incubator-allura-dev-archive@incubator.apache.org Received: (qmail 89816 invoked by uid 500); 9 Dec 2013 20:42:04 -0000 Mailing-List: contact allura-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: allura-dev@incubator.apache.org Delivered-To: mailing list allura-dev@incubator.apache.org Received: (qmail 89808 invoked by uid 99); 9 Dec 2013 20:42:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Dec 2013 20:42:04 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of noreply@sourceforge.net designates 216.34.181.60 as permitted sender) Received: from [216.34.181.60] (HELO smtp.ch3.sourceforge.com) (216.34.181.60) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Dec 2013 20:41:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.com; s=x; h=Date:References:In-Reply-To:Message-ID:Subject:Reply-To:From:To:MIME-Version:Content-Type; bh=p/1N6teLffvRNjtvg6HelngbwPI6nkNUZIZLYr4rv7M=; b=VOhoMj3IdfffhnsDNgvbcRevPeW3QXnWfPdadGKsBfE0mbuOR7djeKC2lxIbE3GvB37ZxhMLiDAkyk+NV8FiqH/22VGkQnnhK3WbQSig5/0QlSa+yFVxl0QLgPayZh38krx24fHd5rjG8QdAg1sJLQP7JDNjMDBFXBixuUrKt9g=; Received: from localhost ([127.0.0.1] helo=sfs-alluradaemon-4.v29.ch3.sourceforge.com) by sfs-alluradaemon-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Vq7e5-0006ke-CO for allura-dev@incubator.apache.org; Mon, 09 Dec 2013 20:41:37 +0000 Content-Type: multipart/related; boundary="===============5860879751289232830==" MIME-Version: 1.0 To: allura-dev@incubator.apache.org From: "Cory Johns" Reply-To: "[allura:tickets] " <6958@tickets.allura.p.re.sf.net> Subject: [allura:tickets] #6958 Better ordinal options for install tool API Message-ID:

In-Reply-To: <52a1fe440910d415c605b746.tickets@allura.p.sourceforge.net> References: <52a1fe440910d415c605b746.tickets@allura.p.sourceforge.net> Date: Mon, 09 Dec 2013 20:41:37 +0000 X-Virus-Checked: Checked by ClamAV on apache.org --===============5860879751289232830== Content-Type: multipart/alternative; boundary="===============1063399300636071369==" MIME-Version: 1.0 --===============1063399300636071369== MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit - **status**: in-progress --> code-review - **Size**: --> 1 --- ** [tickets:#6958] Better ordinal options for install tool API** **Status:** code-review **Labels:** allura-api **Created:** Fri Dec 06, 2013 04:41 PM UTC by Dave Brondsema **Last Updated:** Mon Dec 09, 2013 07:20 PM UTC **Owner:** Cory Johns The install_tool API doesn't have any options for setting the order of a new tool. (And the hard-coded calculation for 'ordinal' uses `len(installable_tools)` which isn't correct so the ordinal ends up kind of random). Options I think we should have: * last: make it last * first: make it first * alpha_tool: sort it alphabetically amidst the tools of that type already installed. I think it's fair to assume the rest of the tools are already sorted, so can just loop through them until you find one where the name comes later, and then insert before that. There are lots of possibilities, but alpha_tool is primary use case at the moment. --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. --===============1063399300636071369== MIME-Version: 1.0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit
  • status: in-progress --> code-review
  • Size: --> 1

[tickets:#6958] Better ordinal options for install tool API

Status: code-review
Labels: allura-api
Created: Fri Dec 06, 2013 04:41 PM UTC by Dave Brondsema
Last Updated: Mon Dec 09, 2013 07:20 PM UTC
Owner: Cory Johns

The install_tool API doesn't have any options for setting the order of a new tool. (And the hard-coded calculation for 'ordinal' uses len(installable_tools) which isn't correct so the ordinal ends up kind of random).

Options I think we should have:

  • last: make it last
  • first: make it first
  • alpha_tool: sort it alphabetically amidst the tools of that type already installed. I think it's fair to assume the rest of the tools are already sorted, so can just loop through them until you find one where the name comes later, and then insert before that.

There are lots of possibilities, but alpha_tool is primary use case at the moment.

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

--===============1063399300636071369==-- --===============5860879751289232830==--