incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #5475 Move CSRF token insertion from JS to easywidgets
Date Wed, 04 Dec 2013 16:46:23 GMT
- **status**: code-review --> closed
- **Milestone**: forge-backlog --> forge-dec-13


** [tickets:#5475] Move CSRF token insertion from JS to easywidgets**

**Status:** closed
**Labels:** p3 support 42cc 
**Created:** Mon Dec 17, 2012 09:27 PM UTC by Rich Bowen
**Last Updated:** Tue Nov 26, 2013 10:54 AM UTC
**Owner:** nobody

Standard forms across on Allura have a `_session_id` field inserted by JS.  AJAX forms insert
it themselves.  This is for CSRF protection.

For the standard forms, we can make them work without JS by inserting the field server-side
instead of client-side.  The `ForgeForm` class seems like a useful place to do this.  Other
manually-constructed forms (e.g. I know ForgeImporter templates have some, others are around
too probably) will need it in the jinja template.  A one-line macro seems like a good way
to handle that.

AJAX forms can stay as-is, they use JS already anyway.


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message