incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Igor Bondarenko" <>
Subject [allura:tickets] #6622 Convert or handle Github markdown extensions
Date Tue, 12 Nov 2013 07:54:15 GMT
Closed #469. 

Force-pushed `je/42cc_6622` (rebase)

Some notes:

> The `~~(.*)~~` regex is too greedy. Based on how github does strikeout, I think `~~(\S*?)~~`
is better

`~~(\S*)~~`  is too restrictive, github allows spaces there. We've made that non-greedy though.

> Minor: can `\b` replace `(\s|^)` and `(\s|$)`? I think that'd be cleaner.

Left it in two places (regex for `#<ticket-num>` and `<commit-hash>`). `\b` would
broke rendering of links like `user/project#ticket` and `user/project@hash` if we change those.


** [tickets:#6622] Convert or handle Github markdown extensions**

**Status:** code-review
**Labels:** import github 42cc 
**Created:** Fri Aug 30, 2013 01:55 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 31, 2013 09:27 AM UTC
**Owner:** nobody

When importing github content (tickets, wiki, comments) we should deal with their special
markup.  For example, code blocks with optional language specification:

function fancyAlert(arg) {
  if(arg) {

should be converted to:

function fancyAlert(arg) {
  if(arg) {

And strikethrough `~~example~~` should be converted to `<s>example</s>`.  This
we could possibly support directly in our Markdown renderer if we wanted to.  That would also
allow it to work for Markdown files in git repos (since we won't modify those during import).

Emoji I don't think we should handle (yet?)

Cross-reference syntax
we may want to consider handling.  See also Trac syntax [#6140] handling.

Converting markdown can be tricky to get right, so we have to be careful that we only convert
the right content.  Nested markup, escaped markup, etc. 


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message