incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #6692 Exports should be scriptable
Date Fri, 04 Oct 2013 16:55:28 GMT
I like it.  I have a lot of feedback though:

### bearer tokens

* If I use an invalid access_token, I get a page with status 403 and but the body says "302
Found" and points to http://.../error/document
* minor: template var `authorized_applications` was removed in one place, it's also unnecessary
in PreferencesController.index

Oauth page:

* Consumer Key is repeated for Consumer Secret
* the confirm dialog pops up for the wrong button

Being picky since security is important

* `,` is added.  Why?
* `test_bearer_token` would be better as 4 separate tests so we don't have to worry about
changes to the mock & the request carrying over from one test case to the next.  
* even more tests, like:
    * functional tests of the /auth/oauth/ page
    * functional tests where OAuthAccessToken queries are not mocked. 
    * oauth tests (not your fault) but all we have is a few in `allura/tests/functional/`
that only cover the /auth/oauth/ page (and 2 of those fail & need to be updated).  We
should write the tests since we're touching the functionality a little bit here.

### backup APIs

* Shouldn't ProjectAdminRestController._check_security require 'admin' access?  I can't think
of a case where we'd want admin-level stuff to be exposed to those with just 'read' access.

* the `export` methods of ProjectAdminController and `ProjectAdminRestController` share a
lot in common.  What would you think of ProjectAdminController.export calling ProjectAdminRestController.export
and converting any HTTP exception into a flash message?  The API should have the `bulk_export_enabled`
check too.
* splitting up `test_export` so each case has a name would help me at least (test_export_no_exportable_tools,

### overall

Can we provide a sample shell script that uses the API?  We also need to document the API.
 Particularly note the http codes, e.g. so people know 503 means task busy not server having


** [tickets:#6692] Exports should be scriptable**

**Status:** code-review
**Labels:** export 
**Created:** Fri Sep 20, 2013 05:43 PM UTC by Dave Brondsema
**Last Updated:** Fri Oct 04, 2013 02:54 PM UTC
**Owner:** Cory Johns

Currently difficulties in project exports are:

* requires a manual form submission
* email is used to notify when ready
* resulting filename is non-deterministic

It should be possible to automate a project export with a script, with minimal difficulty.


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message