Return-Path: X-Original-To: apmail-incubator-allura-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-allura-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC59E10E97 for ; Mon, 12 Aug 2013 20:57:23 +0000 (UTC) Received: (qmail 17459 invoked by uid 500); 12 Aug 2013 20:57:21 -0000 Delivered-To: apmail-incubator-allura-dev-archive@incubator.apache.org Received: (qmail 17329 invoked by uid 500); 12 Aug 2013 20:57:21 -0000 Mailing-List: contact allura-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: allura-dev@incubator.apache.org Delivered-To: mailing list allura-dev@incubator.apache.org Received: (qmail 17299 invoked by uid 99); 12 Aug 2013 20:57:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2013 20:57:20 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of noreply@sourceforge.net designates 216.34.181.60 as permitted sender) Received: from [216.34.181.60] (HELO smtp.ch3.sourceforge.com) (216.34.181.60) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2013 20:57:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.com; s=x; h=Date:Message-ID:Subject:Reply-To:From:To:MIME-Version:Content-Type; bh=1/K+S3MUDbGjhwo1My0Obps5lKDu5aBESatyZgVKWkQ=; b=opNWaArIjUThdvKJ1kg3wRJDEmxb5epIsRx1MKqbJF0qk7S/16TYNPMAkg+RTyI3qCXPg97nwcccIU/5zWculFqrXE1q6VWtfvVkaArKEqiZ6M6mIuj7KmoOwd7ovEadWp6wB0I2PqWghmzNBcdApp5bDtGqaw8ZyZiVMYVfvXQ=; Received: from localhost ([127.0.0.1] helo=sfs-alluradaemon-3.v29.ch3.sourceforge.com) by sfs-alluradaemon-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1V8zAd-0005D2-Og for allura-dev@incubator.apache.org; Mon, 12 Aug 2013 20:56:55 +0000 Content-Type: multipart/related; boundary="===============2837831382153345270==" MIME-Version: 1.0 To: "[allura:tickets] " <5177@tickets.allura.p.re.sf.net> From: "Dave Brondsema" Reply-To: "[allura:tickets] " <5177@tickets.allura.p.re.sf.net> Subject: [allura:tickets] #5177 Better branch/commit logic when creating new merge requests Message-ID:

Date: Mon, 12 Aug 2013 20:56:55 +0000 X-Virus-Checked: Checked by ClamAV on apache.org --===============2837831382153345270== Content-Type: multipart/alternative; boundary="===============5302229472166242119==" MIME-Version: 1.0 --===============5302229472166242119== MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Works well, but I'd be happier to see a test case, or enhancement to existing `test_merge_request_*` tests (e.g. something simple like following the link on the sidebar and check that the selected branch is correct) --- ** [tickets:#5177] Better branch/commit logic when creating new merge requests** **Status:** in-progress **Labels:** merge-requests **Created:** Mon Oct 22, 2012 08:44 PM UTC by Dave Brondsema **Last Updated:** Thu Aug 08, 2013 02:05 PM UTC **Owner:** Cory Johns It's easy to create merge requests with the wrong branches & commits specified. It defaults both branch drop-downs to the first one alphabetically. It should default to master for git and default? for hg. Potentially look at the branches to see which one(s) have new commits, to be even smarter about the default options. There should be a warning or error if 0 commits are included in the request. --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. --===============5302229472166242119== MIME-Version: 1.0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit

Works well, but I'd be happier to see a test case, or enhancement to existing test_merge_request_* tests (e.g. something simple like following the link on the sidebar and check that the selected branch is correct)

[tickets:#5177] Better branch/commit logic when creating new merge requests

Status: in-progress
Labels: merge-requests
Created: Mon Oct 22, 2012 08:44 PM UTC by Dave Brondsema
Last Updated: Thu Aug 08, 2013 02:05 PM UTC
Owner: Cory Johns

It's easy to create merge requests with the wrong branches & commits specified. It defaults both branch drop-downs to the first one alphabetically. It should default to master for git and default? for hg. Potentially look at the branches to see which one(s) have new commits, to be even smarter about the default options. There should be a warning or error if 0 commits are included in the request.

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

--===============5302229472166242119==-- --===============2837831382153345270==--