incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Van Steenburgh <tvansteenbu...@gmail.com>
Subject Re: ok to remove Application.tool_version ?
Date Tue, 20 Aug 2013 23:53:45 GMT
I'm +1 on removing it. 


On Tuesday, August 20, 2013 at 6:24 PM, Dave Brondsema wrote:

> 
> I'm doing some cleanup in the ForgeTracker models to make them not use some
> global context vars like c.app Models shouldn't depend on the current context.
> Down this rabbit trail, I get to:
> 
> 
> class Artifact(MappedClass):
> ...
> tool_version = FieldProperty(
> { str: str },
> if_missing=lambda:{c.app.config.tool_name:c.app.__version__})
> 
> 
> And this throws an error if tool_version isn't specified, and c.app isn't set.
> I want to remove tool_version altogether, since it doesn't seem to be used
> anywhere. I have a vague memory of ancient architecture plans to support tools
> with explicit version numbers and upgrade paths and downgrade paths, and I
> assume this artifact-level field is a result of that. We don't have that
> functionality now, and I don't see a strong use-case to re-create it.
> 
> Any reason not to remove Application.tool_version?
> 
> 
> -- 
> Dave Brondsema : dave@brondsema.net (mailto:dave@brondsema.net)
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
> 
> 



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message