Mailing-List: contact allura-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: allura-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of noreply@sourceforge.net
 designates 216.34.181.60 as permitted sender)
Content-Type: multipart/related;
 boundary="===============6092135557828339030=="
MIME-Version: 1.0
To: "[allura:tickets] " <6446@tickets.allura.p.re.sf.net>
From: "Igor Bondarenko" <jetmind@users.sf.net>
Reply-To: "[allura:tickets] " <6446@tickets.allura.p.re.sf.net>
Subject: [allura:tickets] #6446 Forum API should check for posts' status
Message-ID: 
 </p/allura/tickets/6446/ccb5ace7f4dbc7ced1705987aedd03f4ca08b725.tickets@allura.p.sourceforge.net>
Date: Thu, 25 Jul 2013 09:27:36 +0000

--===============6092135557828339030==
Content-Type: multipart/alternative;
 boundary="===============5060861591957404087=="
MIME-Version: 1.0

--===============5060861591957404087==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Closed #400. `je/42cc_6446`


---

** [tickets:#6446] Forum API should check for posts' status**

**Status:** code-review
**Labels:** 42cc allura-api 
**Created:** Wed Jul 10, 2013 03:19 PM UTC by Dave Brondsema
**Last Updated:** Thu Jul 11, 2013 08:36 AM UTC
**Owner:** nobody

The new API in the ForgeDiscussion tool doesn't check for posts' statuses, so it will show 'pending' and 'spam' posts too, which aren't shown on the regular forum view.  This may apply to discussion thread APIs in other tools too (e.g. ticket comments via API).  It's an issue for individual threads URLs and also the API endpoint for a forum which lists the threads (a new thread that is just 1 post that is not "ok" status, shouldn't be listed, just like the web interface)

Perhaps easiest would be to only show "ok" posts no matter what.  Would be a bit nicer if a user with the proper rights could see the pending & spam posts too.  That might be best with an additional flag in the URL to control whether to show those?  Doesn't seem necessary to do that extra stuff at this point though.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.
--===============5060861591957404087==
MIME-Version: 1.0
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit

<div class="markdown_content"><p>Closed #400. <code>je/42cc_6446</code></p>
<hr />
<p><strong> <a class="alink" href="http://sourceforge.net/p/allura/tickets/6446/">[tickets:#6446]</a> Forum API should check for posts' status</strong></p>
<p><strong>Status:</strong> code-review<br />
<strong>Labels:</strong> 42cc allura-api <br />
<strong>Created:</strong> Wed Jul 10, 2013 03:19 PM UTC by Dave Brondsema<br />
<strong>Last Updated:</strong> Thu Jul 11, 2013 08:36 AM UTC<br />
<strong>Owner:</strong> nobody</p>
<p>The new API in the ForgeDiscussion tool doesn't check for posts' statuses, so it will show 'pending' and 'spam' posts too, which aren't shown on the regular forum view.  This may apply to discussion thread APIs in other tools too (e.g. ticket comments via API).  It's an issue for individual threads URLs and also the API endpoint for a forum which lists the threads (a new thread that is just 1 post that is not "ok" status, shouldn't be listed, just like the web interface)</p>
<p>Perhaps easiest would be to only show "ok" posts no matter what.  Would be a bit nicer if a user with the proper rights could see the pending &amp; spam posts too.  That might be best with an additional flag in the URL to control whether to show those?  Doesn't seem necessary to do that extra stuff at this point though.</p>
<hr />
<p>Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to <a href="https://sourceforge.net/p/allura/tickets/">https://sourceforge.net/p/allura/tickets/</a></p>
<p>To unsubscribe from further messages, a project admin can change settings at <a href="https://sourceforge.net/p/allura/admin/tickets/options.">https://sourceforge.net/p/allura/admin/tickets/options.</a>  Or, if this is a mailing list, you can unsubscribe from the mailing list.</p></div>
--===============5060861591957404087==--

--===============6092135557828339030==--