Mailing-List: contact allura-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: allura-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of noreply@sourceforge.net
 designates 216.34.181.60 as permitted sender)
Content-Type: multipart/related;
 boundary="===============1904236374727418308=="
MIME-Version: 1.0
To: "[allura:tickets] " <6211@tickets.allura.p.re.sf.net>
From: "Dave Brondsema" <brondsem@users.sf.net>
Reply-To: "[allura:tickets] " <6211@tickets.allura.p.re.sf.net>
Subject: [allura:tickets] #6211 widget template shouldn't extend
 g.theme.master
Message-ID: 
 </p/allura/tickets/6211/abe9301d745fef54615bf50df807505d357f7de9.tickets@allura.p.sourceforge.net>
Date: Mon, 01 Jul 2013 16:36:06 +0000

--===============1904236374727418308==
Content-Type: multipart/alternative;
 boundary="===============6304672214098034690=="
MIME-Version: 1.0

--===============6304672214098034690==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

- **status**: code-review --> closed
- **Milestone**: forge-backlog --> forge-jul-12


---

** [tickets:#6211] widget template shouldn't extend g.theme.master**

**Status:** closed
**Labels:** stability 42cc 
**Created:** Tue May 07, 2013 07:35 PM UTC by Dave Brondsema
**Last Updated:** Mon Jul 01, 2013 02:43 PM UTC
**Owner:** nobody

allura/templates/discussion/index.html isn't a full template that extends g.theme.master  ON forum browse pages, it eventually calls forgediscussion/templates/discussion_widgets/discussion.html which is a widget template but does extend g.theme.master  That is non-standard and has the effect of template globals (like `config`) not being present within the `custom_js` theme macro.

We should see if these templates (and any other related ones) can be made more standard, to avoid such issues.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.
--===============6304672214098034690==
MIME-Version: 1.0
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit

<div class="markdown_content"><ul>
<li><strong>status</strong>: code-review --&gt; closed</li>
<li><strong>Milestone</strong>: forge-backlog --&gt; forge-jul-12</li>
</ul>
<hr />
<p><strong> <a class="alink" href="http://sourceforge.net/p/allura/tickets/6211/">[tickets:#6211]</a> widget template shouldn't extend g.theme.master</strong></p>
<p><strong>Status:</strong> closed<br />
<strong>Labels:</strong> stability 42cc <br />
<strong>Created:</strong> Tue May 07, 2013 07:35 PM UTC by Dave Brondsema<br />
<strong>Last Updated:</strong> Mon Jul 01, 2013 02:43 PM UTC<br />
<strong>Owner:</strong> nobody</p>
<p>allura/templates/discussion/index.html isn't a full template that extends g.theme.master  ON forum browse pages, it eventually calls forgediscussion/templates/discussion_widgets/discussion.html which is a widget template but does extend g.theme.master  That is non-standard and has the effect of template globals (like <code>config</code>) not being present within the <code>custom_js</code> theme macro.</p>
<p>We should see if these templates (and any other related ones) can be made more standard, to avoid such issues.</p>
<hr />
<p>Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to <a href="https://sourceforge.net/p/allura/tickets/">https://sourceforge.net/p/allura/tickets/</a></p>
<p>To unsubscribe from further messages, a project admin can change settings at <a href="https://sourceforge.net/p/allura/admin/tickets/options.">https://sourceforge.net/p/allura/admin/tickets/options.</a>  Or, if this is a mailing list, you can unsubscribe from the mailing list.</p></div>
--===============6304672214098034690==--

--===============1904236374727418308==--