incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <brond...@users.sf.net>
Subject [allura:tickets] #6211 widget template shouldn't extend g.theme.master
Date Mon, 01 Jul 2013 16:36:06 GMT
- **status**: code-review --> closed
- **Milestone**: forge-backlog --> forge-jul-12



---

** [tickets:#6211] widget template shouldn't extend g.theme.master**

**Status:** closed
**Labels:** stability 42cc 
**Created:** Tue May 07, 2013 07:35 PM UTC by Dave Brondsema
**Last Updated:** Mon Jul 01, 2013 02:43 PM UTC
**Owner:** nobody

allura/templates/discussion/index.html isn't a full template that extends g.theme.master 
ON forum browse pages, it eventually calls forgediscussion/templates/discussion_widgets/discussion.html
which is a widget template but does extend g.theme.master  That is non-standard and has the
effect of template globals (like `config`) not being present within the `custom_js` theme
macro.

We should see if these templates (and any other related ones) can be made more standard, to
avoid such issues.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message