incubator-allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #6053 Check for disabled users in user lookups
Date Tue, 25 Jun 2013 01:59:47 GMT
This change seems unnecessary and tests pass without it, so I'm going to merge without it,
unless there's some reason we need it:

--- Allura/allura/controllers/
+++ Allura/allura/controllers/
@@ -123,6 +123,8 @@ def __call__(self, environ, start_response):
         c.project = M.Project.query.get(shortname='test', neighborhood_id=self.p_nbhd._id)
         auth = plugin.AuthenticationProvider.get(request)
         user = auth.by_username(environ.get('username', 'test-admin'))
+        if not user:
+            user = M.User.by_username('test-admin')
         environ['beaker.session']['userid'] = user._id
         c.user = auth.authenticate_request()
         return WsgiDispatchController.__call__(self, environ, start_response)


** [tickets:#6053] Check for disabled users in user lookups**

**Status:** closed
**Labels:** 42cc 
**Created:** Thu Apr 04, 2013 09:25 PM UTC by Dave Brondsema
**Last Updated:** Fri Jun 21, 2013 04:27 PM UTC
**Owner:** nobody

identify_sender() calls claimed_by_user() which should only select where disabled:false

We should survey for other places that should check the relatively-new disabled field for


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message