Mailing-List: contact allura-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: allura-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of wwitzel3@gmail.com designates
 209.85.160.47 as permitted sender)
Date: Fri, 3 Aug 2012 13:43:35 -0700
From: Wayne Witzel III <wwitzel3@gmail.com>
To: allura-dev@incubator.apache.org
Message-ID: <6B081DC4562548FAA3D0B166372DC2DB@gmail.com>
In-Reply-To: <501C3662.2000308@brondsema.net>
References: <501C3662.2000308@brondsema.net>
Subject: Re: handling optional GPL dependencies
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="501c37f7_7e0c57b1_7b60"

--501c37f7_7e0c57b1_7b60
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Friday, August 3, 2012 at 1:36 PM, Dave Brondsema wrote:
> 
> 1) How to run the importer tests. I'm thinking they should
> automatically skip if the mediawiki package is not present. An
> alternative would be to move them to some location so that they are not
> run by default, and would have to be manually run.

I like the idea of checking for the mediawiki package and then marking them as skip if that package is not found. 
> 
> 2) Where to define the dependency. Currently all deps are listed in
> requirements-common.txt which is used during regular installation. It
> should not be there since it'll be optional. We could have a
> requirements-optional.txt and put all optional deps there. But that
> could grow to be a hodge-podge and only useful if someone wants
> absolutely everything (e.g. during a test suite run). I think also the
> importer script should give specific installation instruction if it is
> attempted to be run.
> 
This won't be the only time we run in to this ( we have reps now that are GPL) and I think having a requirements-optional.txt is a fine way to deal with it. I think it will let us prune down our current requirements some as well, which is good. I'd rather have a core set of requirements and have the hodge-podge exist in a file named optional. 

Wayne
--501c37f7_7e0c57b1_7b60--