incubator-adffaces-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Lowe" <chris.lowe...@gmail.com>
Subject Re: CSS Conditional Comments Bug?
Date Fri, 19 Jan 2007 09:33:25 GMT
That's a relief.  Going forward, are you happy dealing with it or should I
open a JIRI case?  I appreciate you guys are busy, so if there is anything I
can do to help then just ask.

Best Regards,

Chris.



On 19/01/07, Adam Winer <awiner@gmail.com> wrote:
>
> No, it should not be adding spaces.
>
> -- Adam
>
>
> On 1/18/07, Chris Lowe <chris.lowe.uk@gmail.com> wrote:
> >
> > Hi,
> >
> > I have some CSS conditional comments in my facelets code:
> >
> > <!--[if IE 6]>
> > <p>IE 6.0</p>
> > <![endif]-->
> >
> > However, when this is rendered I get a spaces introduced around the
> > opening/closing comments:
> >
> > <!-- [if IE 6]>
> > <p>IE 6.0</p>
> > <![endif] -->
> >
> > This prevents the CSS conditional from being parsed in IE.
> >
> > After some snooping, I found the problem lies in the class
> > org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292 and
> > 294: <http://org.apache.myfaces.trinidadinternal.io>
> >
> >   @Override
> >   public void writeComment(Object comment) throws IOException
> >   {
> >     if (comment != null)
> >     {
> >       _closeStartIfNecessary();
> >       _out.write("<!-- ");
> >       _out.write(comment.toString());
> >       _out.write(" -->");
> >     }
> >   }
> >
> > Should this method be adding spaces?  Should I raise a case / submit a
> > patch
> > for this?
> >
> > Regards,
> >
> > Chris.
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message