From adffaces-user-return-495-apmail-incubator-adffaces-user-archive=incubator.apache.org@incubator.apache.org Mon Jul 17 10:56:01 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-user-archive@locus.apache.org Received: (qmail 33286 invoked from network); 17 Jul 2006 10:56:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Jul 2006 10:56:01 -0000 Received: (qmail 4947 invoked by uid 500); 17 Jul 2006 10:56:00 -0000 Delivered-To: apmail-incubator-adffaces-user-archive@incubator.apache.org Received: (qmail 4930 invoked by uid 500); 17 Jul 2006 10:56:00 -0000 Mailing-List: contact adffaces-user-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-user@incubator.apache.org Delivered-To: mailing list adffaces-user@incubator.apache.org Received: (qmail 4921 invoked by uid 99); 17 Jul 2006 10:56:00 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 03:56:00 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of cosmacol@gmail.com designates 66.249.92.172 as permitted sender) Received: from [66.249.92.172] (HELO ug-out-1314.google.com) (66.249.92.172) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 03:55:59 -0700 Received: by ug-out-1314.google.com with SMTP id u40so1654808ugc for ; Mon, 17 Jul 2006 03:55:38 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=P48mjT4KeEpZNrzIhFrDBlM9FCSlRGdnunqXOOQZj3FSVlm5Tt5f6lE73aKbydbP5Fmx9Mf1a023tYnpDMFfME6wGg6eSG5Ec1Unh1rCgZul/740HkZK1bNk7by0EK0DrTMM8JiA9Mh/5zPX+AWwHGb14ZgPTKiw7LTfVevDv9M= Received: by 10.66.219.11 with SMTP id r11mr2358810ugg; Mon, 17 Jul 2006 03:55:38 -0700 (PDT) Received: by 10.67.105.12 with HTTP; Mon, 17 Jul 2006 03:55:37 -0700 (PDT) Message-ID: <467251f60607170355k1e2e1a93p2e9d794b4b380feb@mail.gmail.com> Date: Mon, 17 Jul 2006 12:55:37 +0200 From: "Cosma Colanicchia" To: adffaces-user@incubator.apache.org Subject: Re: ADF Faces breaks many Tomahawk components In-Reply-To: <5a99335f0607170343p5efe4b88pde38cb78f8debbf2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <467251f60605230702i59d0888j174501880486ffad@mail.gmail.com> <467251f60607162353n72ebff7k516d1e0401c2704e@mail.gmail.com> <71235db40607170047j69625d0cy3cc52d98e5b6a27f@mail.gmail.com> <467251f60607170056p1ef711dcq143c5cde7e52d6d0@mail.gmail.com> <467251f60607170119g74f0f692kbd080afe55add00c@mail.gmail.com> <467251f60607170122n21fd9fdcgf44674bef5283487@mail.gmail.com> <467251f60607170125p25da0818u698cc1f2ada121d8@mail.gmail.com> <5a99335f0607170213g2a8b6a15l6f0e9460ac13908c@mail.gmail.com> <467251f60607170339s1c5b48eauccb9c07fa3384de6@mail.gmail.com> <5a99335f0607170343p5efe4b88pde38cb78f8debbf2@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N This makes things more complex.. anyway, I don't clearly see your solution: will it solve the JSCookMenu problem? There we have a javascript code that explicitly search a form field with a fixed name (see MyFacesHack.js), that is added by the form renderer. Question: is there any reason for components that need an hidden field, to dinamically add one component to the tree that renders it? I see two problem with this: 1) If it is done in the renderer of component A child of form B, are we sure that a child added to B at this stage would get rendered? 2) Does a standard component to render an hidden field that is not value-bounded exists? Cosma 2006/7/17, Martin Marinschek : > Right now, no way. We don't have a common codebase between Trinidad > and Tomahawk. I wonder if this is a problem that can be solved on a > purely javascript basis - client side. How about each link attaching > itself as a submit handler? > > Werner, what do you think? Javascript nightmares ahead? > > regards, > > Martin > > On 7/17/06, Cosma Colanicchia wrote: > > First attemp: > > > > move addHiddenCommandParameter method in an external interface (such > > as FormRendererUtils), and make both Trinidad and MyFaces form > > renderers implement it. Components that need that service must then > > code against that interface, and deal with renderers that doesn't > > implement it. > > > > At least, this way we can control/check at compile time the usage of > > those non-standard services. > > > > Cosma > > > > 2006/7/17, Martin Marinschek : > > > We should fix this. Once and for all. > > > > > > Any suggestions? > > > > > > regards, > > > > > > Martin > > > > > > On 7/17/06, Cosma Colanicchia wrote: > > > > I've only modified the JSCookMenu javascript to create that field in > > > > the DOM if it isn't there. It's not an elegant solution, I know.. > > > > > > > > Cosma > > > > > > > > > > > > 2006/7/17, Cosma Colanicchia : > > > > > P.S. I think that a component relying on other renderers isn't a good > > > > > design and we should try to avoid it.. > > > > > > > > > > > > > > > 2006/7/17, Cosma Colanicchia : > > > > > > It looks like Martin has done a similar work, fixing all the form > > > > > > searching routines, so that part of my patch should be dropped. The > > > > > > addHiddenCommandParameter problem seems to be still there.. do we want > > > > > > to wait for a complete solution or, in the meantime, apply the js hack > > > > > > to make JSCookMenu work? > > > > > > > > > > > > > > > > > > Cosma > > > > > > > > > > > > > > > > > > 2006/7/17, Cosma Colanicchia : > > > > > > > Yes, I mean TOMAHAWK-516, it includes a change that is very similar to > > > > > > > the Martin code, with other things: > > > > > > > > > > > > > > 1) The _ComponentUtils method is not used everywhere. For example, > > > > > > > HtmlJSCookMenuRenderer implements one of its own, and other > > > > > > > rendererers do it as well. I tried to refactor those method to use the > > > > > > > _ComponentUtils one, see the JIRA for details. > > > > > > > > > > > > > > 2) Another potential source of trouble for Trinidad/Tomahawk > > > > > > > integration is the HtmlFormRendererBase.addHiddenCommandParameter > > > > > > > method. This is called at least by the JSCookMenu (but presumibly also > > > > > > > by other components) to queue adding hidden form parameters, but with > > > > > > > that rendered will not be used in a Trinidad project leading to > > > > > > > javascript errors. In my patch for JSCookMenu I workarounded this > > > > > > > hacking into MyFacesHack.js, but I think it should be addressed > > > > > > > someway. > > > > > > > > > > > > > > Well I don't know SVN very well, but if it works as CVS we have two > > > > > > > different patch applied to the same lines of code (the > > > > > > > _ComponentUtils.findNestingForm method), so a merge will be required > > > > > > > if TOMAHAWK-516 will be commited. > > > > > > > > > > > > > > > > > > > > > Cosma > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2006/7/17, Matthias Wessendorf : > > > > > > > > Yes that stuff is committed. _CompontUtils too. > > > > > > > > > > > > > > > > You mean TOMAHAWK-516 ? I just asigned it to me. > > > > > > > > Will (or must) take a look on it. > > > > > > > > > > > > > > > > Can you please give an update of the status ? > > > > > > > > Also what's the *conflict* now is? > > > > > > > > > > > > > > > > Would be great! > > > > > > > > > > > > > > > > -Matthias > > > > > > > > > > > > > > > > On 7/16/06, Cosma Colanicchia wrote: > > > > > > > > > Martin, > > > > > > > > > > > > > > > > > > have you already committed that change? As I pointed out in another > > > > > > > > > thread, I've submitted a patch that will likely conflict with yours if > > > > > > > > > commited. > > > > > > > > > > > > > > > > > > > > > > > > > > > Ciao > > > > > > > > > Cosma > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2006/7/17, Martin Marinschek : > > > > > > > > > > As a workaround for the form problem, I've made the form searching > > > > > > > > > > routing of MyFaces aware of the Trinidad form family - so the trinidad > > > > > > > > > > form should be found as well. > > > > > > > > > > > > > > > > > > > > I'd be glad about any test results! > > > > > > > > > > > > > > > > > > > > regards, > > > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/26/06, Cosma Colanicchia wrote: > > > > > > > > > > > Thomas, I'm using the MyFaces RI. I think that the > > > > > > > > > > > problem is related to *not* using the MyFaces renderer for the > > > > > > > > > > > component (like in TOMAHAWK-416). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2006/5/25, Thomas Spiegl : > > > > > > > > > > > > Cosma, seems like you are using the Sun RI as JSF implementation. > > > > > > > > > > > > > > > > > > > > > > > > see http://issues.apache.org/jira/browse/TOMAHAWK-416 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/25/06, Martin Marinschek wrote: > > > > > > > > > > > > > So it is a must that a renderer for a certain component family needs > > > > > > > > > > > > > to be able to render out all components belonging to this family? I > > > > > > > > > > > > > don't see why you couldn't just use a different renderer-type for the > > > > > > > > > > > > > UIXForm component... > > > > > > > > > > > > > > > > > > > > > > > > > > regards, > > > > > > > > > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/24/06, Adam Winer wrote: > > > > > > > > > > > > > > On 5/24/06, Martin Marinschek wrote: > > > > > > > > > > > > > > > Hi Adam, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I don't remember a thread talking about component families, we only > > > > > > > > > > > > > > > talked about extending from UIForm - so UIXForm does not even have the > > > > > > > > > > > > > > > same component family as UIForm? > > > > > > > > > > > > > > > > > > > > > > > > > > > > No, it doesn't, which is more-or-less implied by not extending UIForm. > > > > > > > > > > > > > > In general, component family should follow subclassing > > > > > > > > > > > > > > as well, because otherwise you'd get ClassCastExceptions in > > > > > > > > > > > > > > Renderers. > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Adam > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/24/06, Adam Winer wrote: > > > > > > > > > > > > > > > > Actually, probably not... UIXForm is in a different component > > > > > > > > > > > > > > > > family from UIForm. (An earlier thread talked about that.) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Adam > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/24/06, Martin Marinschek wrote: > > > > > > > > > > > > > > > > > Problem 1) should have been fixed by Mario's recent addition of > > > > > > > > > > > > > > > > > searching for the component family instead of the instance of UIForm. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 5/24/06, Cosma Colanicchia wrote: > > > > > > > > > > > > > > > > > > I've done some other tries: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 1) When using the component, a dummy form and its clear > > > > > > > > > > > > > > > > > > method are created. Clicking on or > > > > > > > > > > > > > > > > > > does trigger a submit, but the expected > > > > > > > > > > > > > > > > > > behaviour isn't executed. Probably this is because the _link_hidden_ > > > > > > > > > > > > > > > > > > value is set telling JSF that a "linkDummyForm:commandLinkId" has been > > > > > > > > > > > > > > > > > > triggered, but the actual name of the component is different (its name > > > > > > > > > > > > > > > > > > contaner has a different id). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2) When using an component, the dummy form isn't created > > > > > > > > > > > > > > > > > > (seems that the recognize its parent form), but no > > > > > > > > > > > > > > > > > > clear_ method is generated in the page, so the onclick javascript > > > > > > > > > > > > > > > > > > fails to submit the form. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cosma > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2006/5/23, Cosma Colanicchia : > > > > > > > > > > > > > > > > > > > It would be useful to share info about making they work togheter, if > > > > > > > > > > > > > > > > > > > someone has resolved these problems. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Anyway I'm using the latest snapshots.. and I tried with both > > > > > > > > > > > > > > > > > > > and . I had some issues with dummyForm at first, if I can get > > > > > > > > > > > > > > > > > > > some detail I'll try to post it tomorrow, now I'm leaving the office. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bye > > > > > > > > > > > > > > > > > > > Cosma > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2006/5/23, Matthias Wessendorf : > > > > > > > > > > > > > > > > > > > > Hi- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > time by time there are people on the list, using both. > > > > > > > > > > > > > > > > > > > > MyFaces (incl. Tomahawk) and ADF Faces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 1) components (and s) don't work, > > > > > > > > > > > > > > > > > > > > > > > because the MyFaces javascript functions such as clear_myFormId don't get > > > > > > > > > > > > > > > > > > > > > > > generated. Also the _link_hidden_form isn't generated anymore. The rendered > > > > > > > > > > > > > > > > > > > > > > > HTML includes the string , and looking at the > > > > > > > > > > > > > > > > > > > > > > > stack I can see that both the adfFaces and the ExtensionsFilter are invoked, > > > > > > > > > > > > > > > > > > > > > > > but no MyFaces script are actually rendered in the page. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'm not sure why this would happen, but this may be a MyFaces > > > > > > > > > > > > > > > > > > > > > > bug; I know there's been some discussion on the main MyFaces > > > > > > > > > > > > > > > > > > > > > > list about issues like this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'll try to search more carefully in the archives.. do you know if > > > > > > > > > > > > > > > > > > > > > someone had success using MyFaces, Tomahawk and ADF Faces in a > > > > > > > > > > > > > > > > > > > > > project? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Which version (of MyFaces) are you using? > > > > > > > > > > > > > > > > > > > > Can you wrapp around commandLink? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > There where some issue - discussed on myfaces dev - regarding "auto > > > > > > > > > > > > > > > > > > > > generated form" aka dummy form > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -Matthias > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://www.irian.at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Your JSF powerhouse - > > > > > > > > > > > > > > > > > JSF Consulting, Development and > > > > > > > > > > > > > > > > > Courses in English and German > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://www.irian.at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Your JSF powerhouse - > > > > > > > > > > > > > > > JSF Consulting, Development and > > > > > > > > > > > > > > > Courses in English and German > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > http://www.irian.at > > > > > > > > > > > > > > > > > > > > > > > > > > Your JSF powerhouse - > > > > > > > > > > > > > JSF Consulting, Development and > > > > > > > > > > > > > Courses in English and German > > > > > > > > > > > > > > > > > > > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > http://www.irian.at > > > > > > > > > > > > > > > > > > > > > > > > Your JSF powerhouse - > > > > > > > > > > > > JSF Consulting, Development and > > > > > > > > > > > > Courses in English and German > > > > > > > > > > > > > > > > > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > http://www.irian.at > > > > > > > > > > > > > > > > > > > > Your JSF powerhouse - > > > > > > > > > > JSF Consulting, Development and > > > > > > > > > > Courses in English and German > > > > > > > > > > > > > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Matthias Wessendorf > > > > > > > > > > > > > > > > further stuff: > > > > > > > > blog: http://jroller.com/page/mwessendorf > > > > > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > http://www.irian.at > > > > > > Your JSF powerhouse - > > > JSF Consulting, Development and > > > Courses in English and German > > > > > > Professional Support for Apache MyFaces > > > > > > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces >