[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495116
]
Blake Sullivan commented on ADFFACES-266:
-----------------------------------------
I assume that the problem is that supportsAdvancedForms(arc) is returning false for your
Agent because your agent doesn't support <button>. In that case we really want useButtonTags
to be able to return a value indicating the three choices, <a>, <button>, or <input>.
If we don't care about subclasses (of which there are none in Trinidad), the easiest thing
to do would be to inline useButtonTags into the one place where it is called.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495108
]
Jeanne Waldman commented on ADFFACES-338:
-----------------------------------------
If you add a new styleclass that you want to skin, you need to document it in skin-selectors.xml.
> adding styles to panelLabelAndMessage Help-facet
> ------------------------------------------------
>
> Key: ADFFACES-338
> URL: https://issues.apache.org/jira/browse/ADFFACES-338
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_dec21_2_14PM_panelLabelAndMessage_help_facet_styling.patch
>
>
> panelLAbelAndMessage help-facet is not styled. I will add a styling class for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Jeanne Waldman (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495100
]
>
> Jeanne Waldman commented on ADFFACES-266:
> -----------------------------------------
>
> Yes, but what about all the devices that do not support JS? You've changed "a" to "input"
for everything, not just for PDA.
>
I completely agree with Jeanne. The question is why doesn't:
protected boolean useButtonTags(RenderingContext arc)
{
return (supportsScripting(arc) &&
supportsAdvancedForms(arc) &&
supportsIntrinsicEvents(arc));
}
return true for your PDA?
-- Blake Sullivan
>
>> goButton on PDAs should be rendererd as a linked button and not a button
>> ------------------------------------------------------------------------
>>
>> Key: ADFFACES-266
>> URL: https://issues.apache.org/jira/browse/ADFFACES-266
>> Project: MyFaces ADF-Faces
>> Issue Type: Improvement
>> Environment: PDA
>> Reporter: Piyush Hari
>> Priority: Minor
>> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>>
>>
>> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>>
>> String element = useButtonTag ? "button" : "a";
>>
>> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.
>>
>
>
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495100
]
Jeanne Waldman commented on ADFFACES-266:
-----------------------------------------
Yes, but what about all the devices that do not support JS? You've changed "a" to "input"
for everything, not just for PDA.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494972
]
Piyush Hari commented on ADFFACES-266:
--------------------------------------
Jeanne,
I had brought it up earlier on the list when I submitted the patch. Adam replied saying that
"a href" was used instead of "input" because he thought that all devices other than desktop
where there is no JS support can use links atleast. PDAs DO HAVE JS support. Therefore , I
have "input" element.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494924
]
Jeanne Waldman commented on ADFFACES-266:
-----------------------------------------
Hi Piyush,
It seems a little heavy-handed to switch it from <a> to <input>. It might be
the case for pdas that input is better than a, but maybe there are other reasons why we'd
want to use an a.
boolean useButtonTag = useButtonTags(arc);
String element = useButtonTag ? "button" : "a"; // you have "input" instead of "a".
protected boolean useButtonTags(RenderingContext arc)
{
return (supportsScripting(arc) &&
supportsAdvancedForms(arc) &&
supportsIntrinsicEvents(arc));
}
Can you bring this up on the dev list to be sure? If we can't be sure, then we should only
switch to input in the case of pda.
- Jeanne
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman updated ADFFACES-481:
------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-core-SNAPSHOT
Status: Resolved (was: Patch Available)
committed for Piyush.
svn 537064
> Warning and Info icons don't display on PDAs
> --------------------------------------------
>
> Key: ADFFACES-481
> URL: https://issues.apache.org/jira/browse/ADFFACES-481
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: patch_may03_1_40PM_icon_bug.patch
>
>
> The icon component renders a skin specific icon. Each skin implementation exposes a set
of customizable icons that can be overridden by a custom skin. Each icon is identified by
name. "name" attribute is a name identifying which icon should be rendered. Valid values
depend on the skin-family. Shortcut names exist for ".AFRequiredIcon", ".AFWarningIcon", ".AFInfoIcon",
and ".AFErrorIcon". They are "required", "warning", "info", and "error" respectively.
> For PDAs, "warning" and "info' icons do not display.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman updated ADFFACES-486:
------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-plugins-SNAPSHOT
Status: Resolved (was: Patch Available)
fixed.
svn 537064
> show/hide icons for a Tree component do not display on PDAs.
> ------------------------------------------------------------
>
> Key: ADFFACES-486
> URL: https://issues.apache.org/jira/browse/ADFFACES-486
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDAs
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
> Attachments: patch_may07_1_22PM_treeskin_bug.patch
>
>
> Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the
left of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman reassigned ADFFACES-481:
---------------------------------------
Assignee: Jeanne Waldman
> Warning and Info icons don't display on PDAs
> --------------------------------------------
>
> Key: ADFFACES-481
> URL: https://issues.apache.org/jira/browse/ADFFACES-481
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Attachments: patch_may03_1_40PM_icon_bug.patch
>
>
> The icon component renders a skin specific icon. Each skin implementation exposes a set
of customizable icons that can be overridden by a custom skin. Each icon is identified by
name. "name" attribute is a name identifying which icon should be rendered. Valid values
depend on the skin-family. Shortcut names exist for ".AFRequiredIcon", ".AFWarningIcon", ".AFInfoIcon",
and ".AFErrorIcon". They are "required", "warning", "info", and "error" respectively.
> For PDAs, "warning" and "info' icons do not display.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494920
]
Jeanne Waldman commented on ADFFACES-486:
-----------------------------------------
This is a simple fix. However I am going use an if else so that we don't set the text twice.
Also the Trinidad code needs to use the "{" on their own lines, so I'll fix that.
> show/hide icons for a Tree component do not display on PDAs.
> ------------------------------------------------------------
>
> Key: ADFFACES-486
> URL: https://issues.apache.org/jira/browse/ADFFACES-486
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDAs
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Attachments: patch_may07_1_22PM_treeskin_bug.patch
>
>
> Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the
left of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman reassigned ADFFACES-486:
---------------------------------------
Assignee: Jeanne Waldman
> show/hide icons for a Tree component do not display on PDAs.
> ------------------------------------------------------------
>
> Key: ADFFACES-486
> URL: https://issues.apache.org/jira/browse/ADFFACES-486
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDAs
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Attachments: patch_may07_1_22PM_treeskin_bug.patch
>
>
> Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the
left of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman updated ADFFACES-489:
------------------------------------
Status: Patch Available (was: Open)
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFaces-489-IndentingRW.diff
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space
to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman updated ADFFACES-489:
------------------------------------
Attachment: ADFFaces-489-IndentingRW.diff
adding a patch with the one-line fix.
Added "input" to this:
return ("img".equals(name) ||
"a".equals(name) ||
"br".equals(name) ||
"span".equals(name) ||
"div".equals(name) ||
"area".equals(name) ||
"u".equals(name) ||
"i".equals(name) ||
"input".equals(name) ||
"b".equals(name) ||
"em".equals(name) ||
"strong".equals(name) ||
"map".equals(name) ||
"label".equals(name) ||
"font".equals(name) ||
"table".equals(name) ||
"tbody".equals(name) ||
"tr".equals(name) ||
"nobr".equals(name) ||
"wbr".equals(name) ||
"script".equals(name));
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFaces-489-IndentingRW.diff
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space
to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494885
]
Jeanne Waldman commented on ADFFACES-489:
-----------------------------------------
I think the fix is to "input" to the _isWhiteSpaceSensitive list in IndentingResponseWriter.
If I do this, then the newline after the input element is gone which is what we want.
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space
to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
--------------------------------------------------------------------------------
Key: ADFFACES-489
URL: https://issues.apache.org/jira/browse/ADFFACES-489
Project: MyFaces ADF-Faces
Issue Type: Bug
Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
Environment: Must have DEBUG-OUTPUT set to true.
Reporter: Mark Yvanovich
Fix For: 1.0.1-incubating-plugins-SNAPSHOT
I have a component, selectOneRadio, that renders the following HTML for each radio button:
<span><input type='radio'/></span><label>My Label</label>
The HTML pretty printer is inserting space after the input element, causing extra space to
be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer resolved ADFFACES-488.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-core-SNAPSHOT
2.0.0-incubating-core-SNAPSHOT
Fixed on trunk and latest 1.2 branch.
> TrinidadLogger.warning(Throwable) NPEs if t.getMessage() is null
> ----------------------------------------------------------------
>
> Key: ADFFACES-488
> URL: https://issues.apache.org/jira/browse/ADFFACES-488
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 2.0.0-incubating-core-SNAPSHOT, 1.0.1-incubating-core-SNAPSHOT
> Reporter: Adam Winer
> Assigned To: Adam Winer
> Fix For: 2.0.0-incubating-core-SNAPSHOT, 1.0.1-incubating-core-SNAPSHOT
>
>
> Now that we use ResourceBundles for our loggers so we can have
> translations, it seems that we can get NPEs if you log a Throwable
> where t.getMessage() returns null, as the underlying java.util.logging.Formatter
> formatMessage() code handles MissingResourceExceptions but not
> NullPointerExceptions when it calls into the ResourceBundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
TrinidadLogger.warning(Throwable) NPEs if t.getMessage() is null
----------------------------------------------------------------
Key: ADFFACES-488
URL: https://issues.apache.org/jira/browse/ADFFACES-488
Project: MyFaces ADF-Faces
Issue Type: Bug
Affects Versions: 2.0.0-incubating-core-SNAPSHOT, 1.0.1-incubating-core-SNAPSHOT
Reporter: Adam Winer
Assigned To: Adam Winer
Now that we use ResourceBundles for our loggers so we can have
translations, it seems that we can get NPEs if you log a Throwable
where t.getMessage() returns null, as the underlying java.util.logging.Formatter
formatMessage() code handles MissingResourceExceptions but not
NullPointerExceptions when it calls into the ResourceBundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jijun wang updated ADFFACES-441:
--------------------------------
Attachment: trinidadexc2b.patch
patch to localize exception string based on 536365(part 2 of 2: newly added files)
> Adding localization to logging message and exception
> ----------------------------------------------------
>
> Key: ADFFACES-441
> URL: https://issues.apache.org/jira/browse/ADFFACES-441
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Generic
> Reporter: jijun wang
> Assigned To: Jeanne Waldman
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: trinidad.zip, trinidad2.zip, trinidad2b.zip, trinidad3a.zip, trinidad3b.zip,
trinidadexc1a.patch, trinidadexc1b.patch, trinidadexc2a.patch, trinidadexc2b.patch
>
>
> Proposal:
> 1) use resource bundle for logging message in java files above fine level so those message
could be localized;
> 2) localize part/all exception in java files with resource bundle
> Benefit:
> More information in local language accessible for people in tech support, operation,
deployment, field application etc whose software uses trinidad code
> Details:
> Trinidad-api and trinidad-impl will have their own LoggerBundle.xrts where message to
be localized is defined. A LoggerUtils class will be added as a decorator in each project.
LoggerUtils.createTrinidadLogger will return a TrinidadLogger instance with appropriate resource
bundle attached. Message localization in logging is thus available from java logging by inheritance.
Localization in exception message is achieved by passing localized message to exception. For
both logging and exception, server locale will be used. This might create inconsistency for
exception when client locale and server locale are different. Since an exception not captured
would show both on server logger and client browser, using server locale is more practical.
> Open Issues:
> 1) Current API in TrinidadLogger is not enough to handle logging that contains message,
message parameters and throwable. e.g
> _LOG.warning("Unable to instantiate converterClass:" + converterName, e); would become:
> _LOG.warning("UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e); or
> _LOG.logp(Level.WARNING, ..."UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e)
> But we neither warning() nor logp() has API that would take (...String message, Object
parm, throwable e) as signature. Should we add API or use 2 logging statements?
> _LOG.warning("Unable to instantiate converterClass:" + converterName;
> _LOG.warning(e);
> 2) Should LoggerUtils provide some methods like public static String getMessage(TrinidadLogger
logger, String key (, Object params([])?)?) to retrieve localized string from resource bundle(parameter
substitution could also be done in the method). The alternative is to use TrinidadLogger.getResourceBundle.getString(key)
to retrieve localized message(in this case no parameter substitution or we don't localize
exception message that carries parameters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jijun wang updated ADFFACES-441:
--------------------------------
Attachment: trinidadexc2a.patch
patch to localize exception string based on 536365(part 1 of 2: updated files)
> Adding localization to logging message and exception
> ----------------------------------------------------
>
> Key: ADFFACES-441
> URL: https://issues.apache.org/jira/browse/ADFFACES-441
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Generic
> Reporter: jijun wang
> Assigned To: Jeanne Waldman
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: trinidad.zip, trinidad2.zip, trinidad2b.zip, trinidad3a.zip, trinidad3b.zip,
trinidadexc1a.patch, trinidadexc1b.patch, trinidadexc2a.patch, trinidadexc2b.patch
>
>
> Proposal:
> 1) use resource bundle for logging message in java files above fine level so those message
could be localized;
> 2) localize part/all exception in java files with resource bundle
> Benefit:
> More information in local language accessible for people in tech support, operation,
deployment, field application etc whose software uses trinidad code
> Details:
> Trinidad-api and trinidad-impl will have their own LoggerBundle.xrts where message to
be localized is defined. A LoggerUtils class will be added as a decorator in each project.
LoggerUtils.createTrinidadLogger will return a TrinidadLogger instance with appropriate resource
bundle attached. Message localization in logging is thus available from java logging by inheritance.
Localization in exception message is achieved by passing localized message to exception. For
both logging and exception, server locale will be used. This might create inconsistency for
exception when client locale and server locale are different. Since an exception not captured
would show both on server logger and client browser, using server locale is more practical.
> Open Issues:
> 1) Current API in TrinidadLogger is not enough to handle logging that contains message,
message parameters and throwable. e.g
> _LOG.warning("Unable to instantiate converterClass:" + converterName, e); would become:
> _LOG.warning("UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e); or
> _LOG.logp(Level.WARNING, ..."UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e)
> But we neither warning() nor logp() has API that would take (...String message, Object
parm, throwable e) as signature. Should we add API or use 2 logging statements?
> _LOG.warning("Unable to instantiate converterClass:" + converterName;
> _LOG.warning(e);
> 2) Should LoggerUtils provide some methods like public static String getMessage(TrinidadLogger
logger, String key (, Object params([])?)?) to retrieve localized string from resource bundle(parameter
substitution could also be done in the method). The alternative is to use TrinidadLogger.getResourceBundle.getString(key)
to retrieve localized message(in this case no parameter substitution or we don't localize
exception message that carries parameters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494459
]
Mark Emeny commented on ADFFACES-453:
-------------------------------------
Adam, I just tried something else to thrash out the problem. I removed the row disclosure
listener completely as well as the selection listener, giving me...
<tr:treeTable id="needsTable" value="#{needsSolutionsBB.needModel}" rowSelection="single"
autoSubmit="true" var="need" binding="#{needsSolutionsBB.needTable}" width="100%"></tr:treeTable>
And the underlying problem may now be evident, that is rows are not collapsed or expanded
once something in the tree table has been selected. Without anything being selected the tree
table will expand and collapse correctly but as soon as I select anything nothing expands
or collapses (whether I click on the selected row or not).
If you still need me to come up with a small demo I can do but I'd appreciate it if you could
just try and replicate this first.
> RowDisclosureEvent with treetable select
> ----------------------------------------
>
> Key: ADFFACES-453
> URL: https://issues.apache.org/jira/browse/ADFFACES-453
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Microsoft Windows XP SP2
> Reporter: Mark Emeny
>
> The RowDisclosureEvent doesn't seem to fire when anything is selected in a tree table.
If nothing is selected the event fires but as soon as anything is selected the event fails
to fire.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer resolved ADFFACES-487.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-plugins-SNAPSHOT
2.0.0-incubating-plugins-SNAPSHOT
Assignee: Adam Winer
Fixed on trunk and 1.2 branch.
> Change Component generator to us XXX.valueOf(x) instead of new XXX(x) when converting
between primitives to Objects in components
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-487
> URL: https://issues.apache.org/jira/browse/ADFFACES-487
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Blake Sullivan
> Assigned To: Adam Winer
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT, 1.0.1-incubating-plugins-SNAPSHOT
>
>
> Change Component generator to us XXX.valueOf(x) instead of new XXX(x) when converting
between primitives to Objects in components as this is potentially more efficient and doesn't
require auto-boxing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494445
]
Adam Winer commented on ADFFACES-453:
-------------------------------------
It doesn't reproduce for me, so I think you'll need to either debug on your own to figure
out the problem, or provide a small, self-encapsulated demo that shows the problem.
> RowDisclosureEvent with treetable select
> ----------------------------------------
>
> Key: ADFFACES-453
> URL: https://issues.apache.org/jira/browse/ADFFACES-453
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Microsoft Windows XP SP2
> Reporter: Mark Emeny
>
> The RowDisclosureEvent doesn't seem to fire when anything is selected in a tree table.
If nothing is selected the event fires but as soon as anything is selected the event fails
to fire.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer updated ADFFACES-391:
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-core-SNAPSHOT
Assignee: Adam Winer
Status: Resolved (was: Patch Available)
Checked in patch, after:
- Used trinidad-config.xml instead of web.xml with new <client-validation> element
and RequestContext.getClientValidation() method
- Fixed rendering to support table messages
- Don't change rendering unless inline validation is on
- Temporarily made the validateInput() method private until
we have a good strategy for namespacing JS
> Client-side validation - enhance to match server-side
> -----------------------------------------------------
>
> Key: ADFFACES-391
> URL: https://issues.apache.org/jira/browse/ADFFACES-391
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Danny Robinson
> Assigned To: Adam Winer
> Priority: Minor
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: inlineValidationPatch.patch, inlineValidationPatch.patch, inlineValidationPatch.patch,
inlineValidationPatch.patch
>
>
> Enhance the current client-side validation mechanism to emulate the server-side. Instead
of poping the javascript alert, instead dyamically insert the error messages into the page
in the same way it appears when server-side validation is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Change Component generator to us XXX.valueOf(x) instead of new XXX(x) when converting between
primitives to Objects in components
---------------------------------------------------------------------------------------------------------------------------------
Key: ADFFACES-487
URL: https://issues.apache.org/jira/browse/ADFFACES-487
Project: MyFaces ADF-Faces
Issue Type: Improvement
Components: Plugins
Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
Reporter: Blake Sullivan
Change Component generator to us XXX.valueOf(x) instead of new XXX(x) when converting between
primitives to Objects in components as this is potentially more efficient and doesn't require
auto-boxing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Robinson updated ADFFACES-391:
------------------------------------
Attachment: inlineValidationPatch.patch
Validated against latest revision in myfaces svn.
> Client-side validation - enhance to match server-side
> -----------------------------------------------------
>
> Key: ADFFACES-391
> URL: https://issues.apache.org/jira/browse/ADFFACES-391
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Danny Robinson
> Priority: Minor
> Attachments: inlineValidationPatch.patch, inlineValidationPatch.patch, inlineValidationPatch.patch,
inlineValidationPatch.patch
>
>
> Enhance the current client-side validation mechanism to emulate the server-side. Instead
of poping the javascript alert, instead dyamically insert the error messages into the page
in the same way it appears when server-side validation is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Emeny reopened ADFFACES-453:
---------------------------------
Hi Adam. I tried this again and am still having the same problem. Basically, I have a CoreTreeTable,
defined as such...
<tr:treeTable id="needsTable" value="#{needsSolutionsBB.needModel}" rowSelection="single"
autoSubmit="true" var="need" binding="#{needsSolutionsBB.needTable}" width="100%" expandAllEnabled="false"
rowDisclosureListener="#{needsSolutionsBB.needDisclosed}" selectionListener="#{needsSolutionsBB.needSelected}"></tr:treeTable>
When nothing is selected in the tree my "needDisclosed" method...
public void needDisclosed(RowDisclosureEvent discolsureEvent)
...is fired (and I can see the postback in the browser). However, as soon as I select anything
in the tree the "needDiscolsed" is not fired (although the browser does perform another postback).
I have set a breakpoint at the start of the "needDisclosed" event and the line is hit when
nothing is selected but not hit when anything is selected. The same thing worked fine when
I was using the ADF controls so not sure what has really changed.
Is there anything I can try to give you more details?
> RowDisclosureEvent with treetable select
> ----------------------------------------
>
> Key: ADFFACES-453
> URL: https://issues.apache.org/jira/browse/ADFFACES-453
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Microsoft Windows XP SP2
> Reporter: Mark Emeny
>
> The RowDisclosureEvent doesn't seem to fire when anything is selected in a tree table.
If nothing is selected the event fires but as soon as anything is selected the event fails
to fire.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piyush Hari updated ADFFACES-486:
---------------------------------
Status: Patch Available (was: Open)
> show/hide icons for a Tree component do not display on PDAs.
> ------------------------------------------------------------
>
> Key: ADFFACES-486
> URL: https://issues.apache.org/jira/browse/ADFFACES-486
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may07_1_22PM_treeskin_bug.patch
>
>
> Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the
left of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piyush Hari updated ADFFACES-486:
---------------------------------
Attachment: patch_may07_1_22PM_treeskin_bug.patch
This patch provides a fix for the issue. PDA browsers do not render unicode characters used
to form the triangular icons. For ex : " ► " is used in the rendererd HTML to depict
a '<' arrow. So, these will have to be replaced by text supported on PDA browsers. Since,
we can use '<' and '>' , but won't be able to have an arrow in the downward direction
using standard keyboard characters, I will suggest to use a [+] and [-] for hidden/expanded
cases.
> show/hide icons for a Tree component do not display on PDAs.
> ------------------------------------------------------------
>
> Key: ADFFACES-486
> URL: https://issues.apache.org/jira/browse/ADFFACES-486
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may07_1_22PM_treeskin_bug.patch
>
>
> Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the
left of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
show/hide icons for a Tree component do not display on PDAs.
------------------------------------------------------------
Key: ADFFACES-486
URL: https://issues.apache.org/jira/browse/ADFFACES-486
Project: MyFaces ADF-Faces
Issue Type: Bug
Environment: PDAs
Reporter: Piyush Hari
Priority: Minor
Look at trinidad-demo example on PDAs for Tree component. The show/hide icons to the left
of tree nodes do not render. This needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jijun wang updated ADFFACES-441:
--------------------------------
Attachment: trinidadexc1b.patch
For review only. New file for exception change.
> Adding localization to logging message and exception
> ----------------------------------------------------
>
> Key: ADFFACES-441
> URL: https://issues.apache.org/jira/browse/ADFFACES-441
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Generic
> Reporter: jijun wang
> Assigned To: Jeanne Waldman
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: trinidad.zip, trinidad2.zip, trinidad2b.zip, trinidad3a.zip, trinidad3b.zip,
trinidadexc1a.patch, trinidadexc1b.patch
>
>
> Proposal:
> 1) use resource bundle for logging message in java files above fine level so those message
could be localized;
> 2) localize part/all exception in java files with resource bundle
> Benefit:
> More information in local language accessible for people in tech support, operation,
deployment, field application etc whose software uses trinidad code
> Details:
> Trinidad-api and trinidad-impl will have their own LoggerBundle.xrts where message to
be localized is defined. A LoggerUtils class will be added as a decorator in each project.
LoggerUtils.createTrinidadLogger will return a TrinidadLogger instance with appropriate resource
bundle attached. Message localization in logging is thus available from java logging by inheritance.
Localization in exception message is achieved by passing localized message to exception. For
both logging and exception, server locale will be used. This might create inconsistency for
exception when client locale and server locale are different. Since an exception not captured
would show both on server logger and client browser, using server locale is more practical.
> Open Issues:
> 1) Current API in TrinidadLogger is not enough to handle logging that contains message,
message parameters and throwable. e.g
> _LOG.warning("Unable to instantiate converterClass:" + converterName, e); would become:
> _LOG.warning("UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e); or
> _LOG.logp(Level.WARNING, ..."UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e)
> But we neither warning() nor logp() has API that would take (...String message, Object
parm, throwable e) as signature. Should we add API or use 2 logging statements?
> _LOG.warning("Unable to instantiate converterClass:" + converterName;
> _LOG.warning(e);
> 2) Should LoggerUtils provide some methods like public static String getMessage(TrinidadLogger
logger, String key (, Object params([])?)?) to retrieve localized string from resource bundle(parameter
substitution could also be done in the method). The alternative is to use TrinidadLogger.getResourceBundle.getString(key)
to retrieve localized message(in this case no parameter substitution or we don't localize
exception message that carries parameters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jijun wang updated ADFFACES-441:
--------------------------------
Attachment: trinidadexc1a.patch
For review only. Change on exception part. Check TrinidadLogger.java, FastMessageFormat.java
New files not included.
> Adding localization to logging message and exception
> ----------------------------------------------------
>
> Key: ADFFACES-441
> URL: https://issues.apache.org/jira/browse/ADFFACES-441
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Generic
> Reporter: jijun wang
> Assigned To: Jeanne Waldman
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: trinidad.zip, trinidad2.zip, trinidad2b.zip, trinidad3a.zip, trinidad3b.zip,
trinidadexc1a.patch
>
>
> Proposal:
> 1) use resource bundle for logging message in java files above fine level so those message
could be localized;
> 2) localize part/all exception in java files with resource bundle
> Benefit:
> More information in local language accessible for people in tech support, operation,
deployment, field application etc whose software uses trinidad code
> Details:
> Trinidad-api and trinidad-impl will have their own LoggerBundle.xrts where message to
be localized is defined. A LoggerUtils class will be added as a decorator in each project.
LoggerUtils.createTrinidadLogger will return a TrinidadLogger instance with appropriate resource
bundle attached. Message localization in logging is thus available from java logging by inheritance.
Localization in exception message is achieved by passing localized message to exception. For
both logging and exception, server locale will be used. This might create inconsistency for
exception when client locale and server locale are different. Since an exception not captured
would show both on server logger and client browser, using server locale is more practical.
> Open Issues:
> 1) Current API in TrinidadLogger is not enough to handle logging that contains message,
message parameters and throwable. e.g
> _LOG.warning("Unable to instantiate converterClass:" + converterName, e); would become:
> _LOG.warning("UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e); or
> _LOG.logp(Level.WARNING, ..."UNABLE_INSTANTIATE_CONVERTERCLASS", converterName, e)
> But we neither warning() nor logp() has API that would take (...String message, Object
parm, throwable e) as signature. Should we add API or use 2 logging statements?
> _LOG.warning("Unable to instantiate converterClass:" + converterName;
> _LOG.warning(e);
> 2) Should LoggerUtils provide some methods like public static String getMessage(TrinidadLogger
logger, String key (, Object params([])?)?) to retrieve localized string from resource bundle(parameter
substitution could also be done in the method). The alternative is to use TrinidadLogger.getResourceBundle.getString(key)
to retrieve localized message(in this case no parameter substitution or we don't localize
exception message that carries parameters)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer updated ADFFACES-479:
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-core-SNAPSHOT
Status: Resolved (was: Patch Available)
Checked in the patch - thanks.
> Column headerText attribute should not be rendered if column header facet is present
> ------------------------------------------------------------------------------------
>
> Key: ADFFACES-479
> URL: https://issues.apache.org/jira/browse/ADFFACES-479
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Components
> Reporter: John Fan
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
> Attachments: columnHeaderFacet.patch
>
>
> If a header facet is present in a table column, the headerText attribute of the column
should not be rendered to the table column GUI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer resolved ADFFACES-485.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-incubating-core-SNAPSHOT
Fjxed
> autoSubmit doesn't deliver value change events when inside of a subform
> -----------------------------------------------------------------------
>
> Key: ADFFACES-485
> URL: https://issues.apache.org/jira/browse/ADFFACES-485
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Adam Winer
> Assigned To: Adam Winer
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
>
> autoSubmit="true" input components will post back to the server when inside
> of a subform, but they never deliver ValueChangeEvents, making the feature
> less than helpful.
> To test, open demos/pprDemos.jspx and put a subform inside of the form.
> Note that none of the autoSubmit components do much anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
autoSubmit doesn't deliver value change events when inside of a subform
-----------------------------------------------------------------------
Key: ADFFACES-485
URL: https://issues.apache.org/jira/browse/ADFFACES-485
Project: MyFaces ADF-Faces
Issue Type: Bug
Components: Components
Affects Versions: 1.0.1-incubating-core-SNAPSHOT
Reporter: Adam Winer
Assigned To: Adam Winer
autoSubmit="true" input components will post back to the server when inside
of a subform, but they never deliver ValueChangeEvents, making the feature
less than helpful.
To test, open demos/pprDemos.jspx and put a subform inside of the form.
Note that none of the autoSubmit components do much anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer closed ADFFACES-480.
-------------------------------
Resolution: Incomplete
Need more details about what bug is being described.
> Teste geral ADF-Faces
> ---------------------
>
> Key: ADFFACES-480
> URL: https://issues.apache.org/jira/browse/ADFFACES-480
> Project: MyFaces ADF-Faces
> Issue Type: Test
> Components: Components
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: bruno tonet
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer reassigned ADFFACES-427:
-----------------------------------
Assignee: Matthias Weßendorf
> Broken client decimal number validator
> --------------------------------------
>
> Key: ADFFACES-427
> URL: https://issues.apache.org/jira/browse/ADFFACES-427
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Environment: Windows XP
> Facelets 1.1.2
> Glassfish v2 b33
> 1.0.1-incubating-core-SNAPSHOT
> Reporter: Luka Surija
> Assigned To: Matthias Weßendorf
>
> after switching from m1 to 1.0.1. snapshot, I realize that client validator for decimal
numbers is broken.
> Settings in trinidad-config:
> <number-grouping-separator>.</number-grouping-separator>
> <decimal-separator>,</decimal-separator>
> In faces-config.xml:
> <locale-config>
> <default-locale>hr_HR</default-locale>
> <supported-locale>hr_HR</supported-locale>
> <supported-locale>en</supported-locale>
> </locale-config>
> on code snippet:
> somevalue=7.54355
> Scenario 1:
> <tr:inputText value="#{somevalue}" >
> <tr:convertNumber />
> </tr:inputText>
> <tr:commandButton />
> on value in inputText is shown: 7,54355, but clicking on button, alert window is open
with message:
> Form validation failures:
> 7.54355 is not a number
> Scenario 2:
> <tr:inputText value="#{somevalue}" />
> <tr:commandButton />
> on value in inputText is shown: 7.54355 - not 7,54355
> Scenario 3:
> <tr:inputText value="#{somevalue}" >
> <tr:convertNumber pattern="0.00####"/>
> </tr:inputText>
> <tr:commandButton />
> on value in inputText is shown: 7,54355, and there is no client validation errors.
> On snapshot m1 it worked fine on "scenario 1".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piyush Hari updated ADFFACES-481:
---------------------------------
Status: Patch Available (was: Open)
> Warning and Info icons don't display on PDAs
> --------------------------------------------
>
> Key: ADFFACES-481
> URL: https://issues.apache.org/jira/browse/ADFFACES-481
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may03_1_40PM_icon_bug.patch
>
>
> The icon component renders a skin specific icon. Each skin implementation exposes a set
of customizable icons that can be overridden by a custom skin. Each icon is identified by
name. "name" attribute is a name identifying which icon should be rendered. Valid values
depend on the skin-family. Shortcut names exist for ".AFRequiredIcon", ".AFWarningIcon", ".AFInfoIcon",
and ".AFErrorIcon". They are "required", "warning", "info", and "error" respectively.
> For PDAs, "warning" and "info' icons do not display.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/ADFFACES-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493518
]
Jeanne Waldman commented on ADFFACES-483:
-----------------------------------------
I meant @agent ie in my example above. @agent alone does nothing.
> @agent support for icons
> ------------------------
>
> Key: ADFFACES-483
> URL: https://issues.apache.org/jira/browse/ADFFACES-483
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Skinning
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Jeanne Waldman
> Fix For: 1.0.1-incubating-core-SNAPSHOT
>
>
> We have @agent support for skin selectors that are not icons, but not for icons.
> It would be useful to have different icons for ie than for gecko. For instance, we might
need different margins. And we could do this:
> af|foo::bar-icon {
> content: url(...);
> margin-left: 2px
> }
> @agent {
> af|foo::bar-icon {
> margin-left: 5px
> }
> }
> What we have to do now is introduce a styleclass that goes around the icon in a span.
> af|foo::bar-icon {
> content: url(...);
> }
> af|foo::bar-icon-style {
> margin-left: 2px
> }
> @agent {
> af|foo::bar-icon-style {
> margin-left: 5px
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
@platform support for skinning icons
------------------------------------
Key: ADFFACES-484
URL: https://issues.apache.org/jira/browse/ADFFACES-484
Project: MyFaces ADF-Faces
Issue Type: Improvement
Components: Skinning
Affects Versions: 1.0.1-incubating-core-SNAPSHOT
Reporter: Jeanne Waldman
Fix For: 1.0.1-incubating-core-SNAPSHOT
We have @platform support for skin selectors that are not icons, but not for icons.
windows, macos, linux, solaris, ppc
af|foo::bar-icon {
content: url(...);
margin-left: 2px
}
@platform windows {
af|foo::bar-icon {
margin-left: 5px
}
}
What we have to do now is introduce a styleclass that goes around the icon in a span.
af|foo::bar-icon {
content: url(...);
}
af|foo::bar-icon-style {
margin-left: 2px
}
@agent windows {
af|foo::bar-icon-style {
margin-left: 5px
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
@agent support for icons
------------------------
Key: ADFFACES-483
URL: https://issues.apache.org/jira/browse/ADFFACES-483
Project: MyFaces ADF-Faces
Issue Type: Improvement
Components: Skinning
Affects Versions: 1.0.1-incubating-core-SNAPSHOT
Reporter: Jeanne Waldman
Fix For: 1.0.1-incubating-core-SNAPSHOT
We have @agent support for skin selectors that are not icons, but not for icons.
It would be useful to have different icons for ie than for gecko. For instance, we might need
different margins. And we could do this:
af|foo::bar-icon {
content: url(...);
margin-left: 2px
}
@agent {
af|foo::bar-icon {
margin-left: 5px
}
}
What we have to do now is introduce a styleclass that goes around the icon in a span.
af|foo::bar-icon {
content: url(...);
}
af|foo::bar-icon-style {
margin-left: 2px
}
@agent {
af|foo::bar-icon-style {
margin-left: 5px
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.