incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Commented: (ADFFACES-266) goButton on PDAs should be rendererd as a linked button and not a button
Date Fri, 11 May 2007 01:21:15 GMT

    [ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494924
] 

Jeanne Waldman commented on ADFFACES-266:
-----------------------------------------

Hi Piyush,

It seems a little heavy-handed to switch it from <a> to <input>.  It might be
the case for pdas that input is better than a, but maybe there are other reasons why we'd
want to use an a.

    boolean useButtonTag = useButtonTags(arc);
    String element = useButtonTag ? "button" : "a";  // you have "input" instead of "a".

   
  protected boolean useButtonTags(RenderingContext arc)
  {
    return (supportsScripting(arc) &&
            supportsAdvancedForms(arc) &&
            supportsIntrinsicEvents(arc));
           
  }

Can you bring this up on the dev list to be sure? If we can't be sure, then we should only
switch to input in the case of pda.


- Jeanne

> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
>                 Key: ADFFACES-266
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-266
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>         Environment: PDA
>            Reporter: Piyush Hari
>            Priority: Minor
>         Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>  
> String element = useButtonTag ? "button" : "a";
>  
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN*
support 'input' tag of type 'Button'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message