From adffaces-issues-return-1909-apmail-incubator-adffaces-issues-archive=incubator.apache.org@incubator.apache.org Fri Mar 16 03:07:30 2007 Return-Path: Delivered-To: apmail-incubator-adffaces-issues-archive@locus.apache.org Received: (qmail 33830 invoked from network); 16 Mar 2007 03:07:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Mar 2007 03:07:30 -0000 Received: (qmail 6508 invoked by uid 500); 16 Mar 2007 03:07:38 -0000 Delivered-To: apmail-incubator-adffaces-issues-archive@incubator.apache.org Received: (qmail 6440 invoked by uid 500); 16 Mar 2007 03:07:38 -0000 Mailing-List: contact adffaces-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-issues@incubator.apache.org Delivered-To: mailing list adffaces-issues@incubator.apache.org Received: (qmail 6429 invoked by uid 99); 16 Mar 2007 03:07:38 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 20:07:38 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 20:07:29 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6F27A71407F for ; Thu, 15 Mar 2007 20:07:09 -0700 (PDT) Message-ID: <17684587.1174014429453.JavaMail.jira@brutus> Date: Thu, 15 Mar 2007 20:07:09 -0700 (PDT) From: "Simon Lessard (JIRA)" To: adffaces-issues@incubator.apache.org Subject: [jira] Updated: (ADFFACES-416) Remove usages of assert as a #ifdef C macro In-Reply-To: <5176804.1174014312630.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/ADFFACES-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Lessard updated ADFFACES-416: ----------------------------------- Attachment: ADFFACES-416.patch This patch removes the existing usages of assert as a macro in Trinidad. > Remove usages of assert as a #ifdef C macro > ------------------------------------------- > > Key: ADFFACES-416 > URL: https://issues.apache.org/jira/browse/ADFFACES-416 > Project: MyFaces ADF-Faces > Issue Type: Task > Components: Build > Affects Versions: 2.0.0-incubating-core-SNAPSHOT, 1.0.0-incubating-core-SNAPSHOT > Reporter: Simon Lessard > Assigned To: Simon Lessard > Priority: Trivial > Fix For: 2.0.0-incubating-core-SNAPSHOT, 1.0.0-incubating-core-SNAPSHOT > > Attachments: ADFFACES-416.patch > > > The idea behind Java assert is to have no overhaul at runtime when assert is disabled. However, since assert was introduced with Java 1.4, some abuses of it were found and the emulation of old C macros is one of them. However, that usage should be highly discouraged as it hit the performance (minimally, but it still hit it compared to the initial assert goal) and is relatively hard to read and maintain. > Therefore, it should be forbidden to use assert as the following and existing usage should be removed : > boolean debugEnabled = false; > assert debugEnabled = true; > // ... > if(debugEnabled) > { > // Do some debug processing > } > // ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.