incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott O'Bryan <>
Subject Re: [jira] Updated: (ADFFACES-379) Configurator.endRequest fails to execute under certain conditions
Date Wed, 14 Feb 2007 00:41:37 GMT
Hey Adam,

Good catch.  Thank you.  If you need help merging this into the latest 
1.2 branch let me know.  The patch does not apply cleanly, but merging 
everything is not terribly difficult.


Adam Winer (JIRA) wrote:
>      [
> Adam Winer updated ADFFACES-379:
> --------------------------------
>     Resolution: Fixed
>         Status: Resolved  (was: Patch Available)
> Checked in.  While testing this patch, I noticed some problems with the file upload code,
> in handling of non-ISO-8859-1 characters.  I'm 99% sure these were there before this
> and just unnoticed, but fixed them while the code was in front of me.
>> Configurator.endRequest fails to execute under certain conditions
>> -----------------------------------------------------------------
>>                 Key: ADFFACES-379
>>                 URL:
>>             Project: MyFaces ADF-Faces
>>          Issue Type: Bug
>>          Components: Portlet
>>         Environment: JSR-168
>>            Reporter: Scott O'Bryan
>>         Attachments: 13-ADFFACES-379.patch, 13-ADFFACES-379.patch
>> When the filter is not run (like in a Portlet) there are certain scenarios where
the Configurator.endRequest is not being called.  Looking at the implementation, there is
also RequestContext initialization in Trinidad Filters and a lot of old stuff which is just
muddying the waters and making the cleanup code more complex.
>> We need to remove the obsolete code for RequestContext initialization in the TrinidadPhaseListener
(as this is now handled by the Configurators regardless of whether the filter is run or not,
and clean up handling of Configurator execution outside of the filter usecase.

View raw message