incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott O'Bryan (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Commented: (ADFFACES-364) PartialPageContext optimization bug
Date Wed, 31 Jan 2007 01:34:33 GMT

    [ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468849
] 

Scott O'Bryan commented on ADFFACES-364:
----------------------------------------

Sorry Adam, I just noticed this comment.

I'm not sure that the code above is causing an issue, but you are correct about the assumptions.
 I think the "poll" component will break since it basically does no checking at all.  I'm
having Jeanne reverse this change and I'll have to find another way to provide this functionality.

If you could give me your input though, I would be much appreciative.  There are a handful
of places where we forcePartialRendering in Trinidad.  Do you think it would be acceptable
to figure out whether the PPR capability is enabled BEFORE forcingPartialRendering is executed?
 I mean when I see a "forcePartialRendering" method, I assume it's actually going to Force
us into a Partial Rendering state regardless of capabilities.

Scott

> PartialPageContext optimization bug
> -----------------------------------
>
>                 Key: ADFFACES-364
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-364
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Portlet
>         Environment: JSR-168
>            Reporter: Scott O'Bryan
>         Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal.  Therefore,
Trinidad has PPR disabled.  One can create extensions to Trinidad, however, which would support
PPR in a container-specific fashion.  In these environments, it should be possible to retrieve
a PartialPageContext in a portal environment as this object has uses to Trinidad extension.
 The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability
is not enabled.  This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API.  This
is because the Trinidad renderkit will already not SEND a ppr request in a portal environment,
so it will never "attempt" to retrieve the PartialPageContext in a portal environment.  If
a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE
the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad
will return null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message