incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamran Kashanian (JIRA)" <>
Subject [jira] Updated: (ADFFACES-320) Obfuscation of addition statement where one of the items being added is an increment statement
Date Wed, 06 Dec 2006 22:50:22 GMT
     [ ]

Kamran Kashanian updated ADFFACES-320:

    Attachment: obfuscator.plugin.patch

This patch fixes the stripping of white space characters around the pre/post increment operator.
Note that the fix makes the logic for white space stripping extremely conservative. We now
leave a single white space character around each token (for tokens that were surrounded by
one or more white space characters). The advantage of this is that it prevents errors caused
by aggressively stripping white space characters. The disadvantage is that it increases the
size of the obfuscated javascript code. In the long run, we need to make this configurable,
and I think there is a plan for me to revisit this in the near future.

> Obfuscation of addition statement where one of the items being added is an increment
> ----------------------------------------------------------------------------------------------
>                 Key: ADFFACES-320
>                 URL:
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Build
>         Environment: maven-javascript-plugin
>            Reporter: Matt Cooper
>            Priority: Minor
>         Attachments: obfuscator.plugin.patch
> If you have JavaScript code like the following:
> var x = 1;
> var y = "" + ++x;
> It is a legal operation.  However, if this code is run through the maven-javascript-plugin,
the second line becomes something like this:
> var y=""+++x;
> This yields an invalid increment operand.  Instead, the space between the "+" and the
"++" must be preserved.  I also suspect (but have not tested) this may be a problem with this
code too:
> var a = 1;
> var b = a++ + "";
> I suspect the increment and the decrement tokens in the obfuscater just need to be tagged
as space sensitive (both before and after)--so we don't remove the spaces when compacting
the code.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message