incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Koci (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Reopened: (ADFFACES-152) HtmlCommandButtonRenderer does not encode image url
Date Tue, 14 Nov 2006 21:22:40 GMT
     [ http://issues.apache.org/jira/browse/ADFFACES-152?page=all ]

Martin Koci reopened ADFFACES-152:
----------------------------------

             
Bug is not fixed:
- we can use suggested patch
- or make renderer using method org.apache.myfaces.trinidad.render.CoreRenderer.toUri(Object)

> HtmlCommandButtonRenderer does not encode image url
> ---------------------------------------------------
>
>                 Key: ADFFACES-152
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-152
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>         Environment: MyFaces 1.1.4-snapshot from http://people.apache.org/builds/myfaces/core-1.1.x/
>            Reporter: Martin Koci
>         Assigned To: Adam Winer
>            Priority: Critical
>         Attachments: HtmlCommandButtonRenderer.java.patch
>
>
> HtmlCommandButtonRenderer is rendering image attribute without using encodeUrl on ExternalContext.
I leads to disappearance of all button images, because we use <h:commandButton image="/imageServlet/imageName.gif"
 /> everywhere.
> Proper encoding of URL can be:
> String src = context.getApplication().getViewHandler().getResourceURL(context, imageSrc);
> writer.writeURIAttribute("src", context.getExternalContext().encodeResourceURL(src),
"image");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message