incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Commented: (ADFFACES-196) Allow using of compression (of names) for user suplied CSS class names
Date Mon, 02 Oct 2006 23:52:20 GMT
    [ http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12439350 ] 
            
Jeanne Waldman commented on ADFFACES-196:
-----------------------------------------

What is the use case when a user puts more than one styleClass on the styleClass attribute
and it doesn't work because it doesn't get compressed. In our generated css file we output
both compressed and uncompressed styleclasses.

Here is a generic example of the problem:

<af:inputText styleClass="styleClass1 styleClass2" />

And in the skinning file:

af|inputText.styleClass1.styleClass2

We will generate this in the css:

.af_inputText.styleClass1.styleClass2, .x00.x01.x02 {some css properties}

And in the html we generate:

<span class="x00 styleClass1 styleClass2"><input...</span>

So, this can cause a problem, definitely, because we don't have .x00.styleClass1.styleClass2
in our generated css file. This is only a problem if both conditions are true:
1. The user added their own style classes to the skinning file
2. The user adds more than one style class name in the styleClass attribute.

Can you explain the exact use case that shows the problem you are having?


> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
>                 Key: ADFFACES-196
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-196
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>            Reporter: Martin Koci
>         Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split
styleClass values and pass it in renderStyleClasses.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message