From adffaces-issues-return-679-apmail-incubator-adffaces-issues-archive=incubator.apache.org@incubator.apache.org Fri Aug 11 19:14:03 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-issues-archive@locus.apache.org Received: (qmail 56756 invoked from network); 11 Aug 2006 19:14:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 11 Aug 2006 19:14:03 -0000 Received: (qmail 95030 invoked by uid 500); 11 Aug 2006 19:14:03 -0000 Delivered-To: apmail-incubator-adffaces-issues-archive@incubator.apache.org Received: (qmail 95014 invoked by uid 500); 11 Aug 2006 19:14:03 -0000 Mailing-List: contact adffaces-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-issues@incubator.apache.org Delivered-To: mailing list adffaces-issues@incubator.apache.org Received: (qmail 95005 invoked by uid 99); 11 Aug 2006 19:14:03 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2006 12:14:03 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2006 12:14:02 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3B6AF714293 for ; Fri, 11 Aug 2006 19:11:15 +0000 (GMT) Message-ID: <9798078.1155323475241.JavaMail.jira@brutus> Date: Fri, 11 Aug 2006 12:11:15 -0700 (PDT) From: "Simon Lessard (JIRA)" To: adffaces-issues@incubator.apache.org Subject: [jira] Commented: (ADFFACES-72) Convert Trinidad to Java 5 standards and clean-up code In-Reply-To: <27794951.1153331596598.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12427588 ] Simon Lessard commented on ADFFACES-72: --------------------------------------- Note: If the final patch is applied, I think this issue can be closed as long as people submit Java 5 compliant patches for other issues. There's still some cleaning to do, but considering the amount of patches I already submitted for it, I think a new task issue to remove deprecated API calls and such would be better. > Convert Trinidad to Java 5 standards and clean-up code > ------------------------------------------------------ > > Key: ADFFACES-72 > URL: http://issues.apache.org/jira/browse/ADFFACES-72 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Simon Lessard > Priority: Minor > Attachments: API_1_5_standard.zip, API_template.patch, DEMO_DateField_Java_5.patch, DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip, I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip, UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch > > > This is a non critical long term improvement that should convert existing Trinidad code to Java 5.0 standard: > - Remove references to deprecated API > - Remove unused imports > - Remove unread variables > - Change StringBuffer to StringBuilder where synchronization is not required > - Reduce to minimum the use of raw type collections (they should be used only when calling an external 1.4 API) > - Make all collection generic compliant > - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce potential OutOfBoundsException risks > - Use enums > - Use concurrent API > - Add @Override annotation on overridden methods > - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic enabled collections -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira