From adffaces-issues-return-806-apmail-incubator-adffaces-issues-archive=incubator.apache.org@incubator.apache.org Mon Aug 21 22:48:25 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-issues-archive@locus.apache.org Received: (qmail 32225 invoked from network); 21 Aug 2006 22:48:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 Aug 2006 22:48:25 -0000 Received: (qmail 13135 invoked by uid 500); 21 Aug 2006 22:48:25 -0000 Delivered-To: apmail-incubator-adffaces-issues-archive@incubator.apache.org Received: (qmail 13114 invoked by uid 500); 21 Aug 2006 22:48:24 -0000 Mailing-List: contact adffaces-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-issues@incubator.apache.org Delivered-To: mailing list adffaces-issues@incubator.apache.org Received: (qmail 13104 invoked by uid 99); 21 Aug 2006 22:48:24 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Aug 2006 15:48:24 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Aug 2006 15:48:24 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0231E7142F0 for ; Mon, 21 Aug 2006 22:45:15 +0000 (GMT) Message-ID: <32506686.1156200315006.JavaMail.jira@brutus> Date: Mon, 21 Aug 2006 15:45:15 -0700 (PDT) From: "Gary Kind (JIRA)" To: adffaces-issues@incubator.apache.org Subject: [jira] Updated: (ADFFACES-125) XMLMenuModel needs public getStream() method so that XMLMenuModel can be extended. In-Reply-To: <9935874.1155592573946.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/ADFFACES-125?page=all ] Gary Kind updated ADFFACES-125: ------------------------------- Attachment: trunk.patch Added code to the menu nodes to ensure that their id is always unique. Also had to update the groupNode key, which points to a child node's id to make sure it works properly. SharedNodes models, if used multiple times in a menu model, would have duplicate node id's. The id's must be unique or the menu model will not work. Also, fixed a few misc. comments. Finally, cached the root model's internal hashmaps to eliminate chance of overwrite (since MenuContentHandlerImpl is static). This simplified the API to get the maps from 3 different API's down to 1. > XMLMenuModel needs public getStream() method so that XMLMenuModel can be extended. > ---------------------------------------------------------------------------------- > > Key: ADFFACES-125 > URL: http://issues.apache.org/jira/browse/ADFFACES-125 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Gary Kind > Attachments: trunk.patch, trunk.patch > > > Currently, getStream() is a private method in MenuContentHandlerImpl.java that provides an InputStream to the menu metadata used by the parser to construct the menu model (tree model). Extenders of XMLMenuModel may want to override the default InputStream (derived from the file system). I have added a public getStream() method to XMLMenuModel.java, removed the private getStream() method from MenuContentHandlerImpl.java, and MenuContentHandlerImpl.getTreeModel() calls back to its local menu model's getStream() method. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira