From adffaces-issues-return-769-apmail-incubator-adffaces-issues-archive=incubator.apache.org@incubator.apache.org Thu Aug 17 22:14:15 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-issues-archive@locus.apache.org Received: (qmail 23656 invoked from network); 17 Aug 2006 22:14:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Aug 2006 22:14:14 -0000 Received: (qmail 19762 invoked by uid 500); 17 Aug 2006 22:14:14 -0000 Delivered-To: apmail-incubator-adffaces-issues-archive@incubator.apache.org Received: (qmail 19745 invoked by uid 500); 17 Aug 2006 22:14:14 -0000 Mailing-List: contact adffaces-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-issues@incubator.apache.org Delivered-To: mailing list adffaces-issues@incubator.apache.org Received: (qmail 19736 invoked by uid 99); 17 Aug 2006 22:14:14 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2006 15:14:14 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2006 15:14:13 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 322847142D3 for ; Thu, 17 Aug 2006 22:11:16 +0000 (GMT) Message-ID: <12872303.1155852676203.JavaMail.jira@brutus> Date: Thu, 17 Aug 2006 15:11:16 -0700 (PDT) From: "Joseph Rozier (JIRA)" To: adffaces-issues@incubator.apache.org Subject: [jira] Updated: (ADFFACES-134) Change the Default Size Attribute for Input Text Fields on BlackBerry Browser In-Reply-To: <4198787.1155738613927.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/ADFFACES-134?page=all ] Joseph Rozier updated ADFFACES-134: ----------------------------------- Attachment: adffaces134.patch I'm attaching a patch to fix this issue. This affected the SimpleInputTextRenderer and its subclasses. Instead of adding agent specific code to each subclass, I created the getColumnsAdjustedForAgent method in SimpleInputTextRenderer that subclasses can use. > Change the Default Size Attribute for Input Text Fields on BlackBerry Browser > ----------------------------------------------------------------------------- > > Key: ADFFACES-134 > URL: http://issues.apache.org/jira/browse/ADFFACES-134 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Environment: BlackBerry Browser 4.0 > Reporter: Joseph Rozier > Priority: Minor > Attachments: adffaces134.patch > > > The BlackBerry Browser does not handle the "size" attribute on an input type="text" field correctly. It tends to add much more space for the field than necessary. > The following shows the actual number of capital M's that can fit in the visible area of the input text field when the size specified (using the default font/browser settings) > size=3, BlackBerry 7290=5, BlackBerry 8700=7 > size=6, BlackBerry 7290=10, BlackBerry 8700=12 > size=10, BlackBery 7290=16, BlackBerry 8700=18 > However, I've found that the actual number of characters allows varies widely depending on the device, font chosen by the user, font size chosen by the user, and font-size specified by the skin/style. > This is primarily an issue on the BlackBerry Browser because of limited screen real estate. Compounding this is the fact that the BlackBerry Browser is not horizontally scrollable, so extra wide fields can throw layouts off (as the BlackBerry Browser will wrap the cells in a table row onto multiple lines if the width is too long). > I propose modifying the default size attribute for the input type="text" fields rendered. (For example, trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\renderkit\core\xhtml\SimpleInputTextRenderer.java has hard-coded default input type="text" sizes for the desktop of 30 and the pda of 11; I'd set the default to 6 for the BlackBerry Browser.) > Because of the variability of size attribute to actual display value, I do NOT propose automatically adjusting the tr:inputText columns attribute the user specifies, if any. > Note that the textarea cols attribute is handled correctly on the BlackBerry Browser and does NOT need adjustment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira