incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer (JIRA)" <>
Subject [jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards and clean-up code
Date Wed, 16 Aug 2006 07:00:14 GMT
     [ ]

Adam Winer updated ADFFACES-72:

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

Checked in the final patch.

I'll close this issue out.  Thanks so much Simon for the enormous amount of work getting the
code cleaned up like this!

As for moving forward - esp. figuring out how to keep the code clean - let's tackle that on
the dev list.

> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>                 Key: ADFFACES-72
>                 URL:
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Simon Lessard
>            Priority: Minor
>         Attachments:, API_template.patch, DEMO_DateField_Java_5.patch,
DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch,,, I18N_Java_5.patch,, SubKeyMap_Java_5.patch, TAG_Java_5.patch,,,, XRTS_java_5.patch
> This is a non critical long term improvement that should convert existing Trinidad code
to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling
an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce
potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic
enabled collections

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message