[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: impl_5_standard_a_m.patch
JDK 5 standard for a part of the impl project. Corrected about 1,300 warnings Eclipse was
giving. The patch converts all packages between trinidadinternal.agent and trinidadinternal.metadata.
I did my best to not corect any other bugs found to keep this patch as clean as possible.
I did add some FIXME when I saw some strange pieces of code though.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, impl_5_standard_a_m.patch
>
>
> This is a non critical long term improvement that should convert existing Trinidad code
to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling
an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce
potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic
enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|