incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer (JIRA)" <>
Subject [jira] Updated: (ADFFACES-116) Skinning: support detection of empty styles
Date Mon, 07 Aug 2006 22:26:14 GMT
     [ ]

Adam Winer updated ADFFACES-116:

    Attachment: empty-styles.patch

The following patch is at least a start.  It will change the entry for any completely empty
style in the "short style class map" to the empty string.  The patch also includes a bunch
of fixups noted by Simon Lessard (use of Hashtable instead of HashMap, failure to use Collections.immutableMap()).
 The patch, however, doesn't detect styles that include other styles, but all the included
styles are empty.

> Skinning: support detection of empty styles
> -------------------------------------------
>                 Key: ADFFACES-116
>                 URL:
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Adam Winer
>         Assigned To: Adam Winer
>         Attachments: empty-styles.patch
> For skinning, it is very handy to leave selectors in place to allow skinning of components
even where there is no obvious reason to support skinning at this moment.  However, this can
be very heavyweight for the generated page size (which will lead to each of worse server performance,
worse bandwidth consumption, and excess page layout time at the client).  It would be desirable
to support detection of styles that are empty (and therefore do not need to be rendered).
> FWIW, we're already not outputting any .css entry if the style has no content.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message