incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Lessard (JIRA)" <>
Subject [jira] Updated: (ADFFACES-72) Convert Trinidad to Java 5 standards and clean-up code
Date Wed, 09 Aug 2006 20:44:14 GMT
     [ ]

Simon Lessard updated ADFFACES-72:


Convert ui and uinode packages to Java 5 standard. Considering those will be deleted over
time but also considering we'll still have them for a while, I decided to convert those two
package trees to reduce the amount of warnings shown in Eclipse (and other IDE?). However,
the conversion is MINIMAL, most of the parametrization was done using <Object> so that
almost no line of code was changed.

I now have 461 warnings left in my environment, not counting the XMLMenuModel patch that I
uploaded a while back and was never applied (was buggy or something?). The menu model patch
fix 100~150 warnings, leaving 300ish warnings. If I'm allowed to change RowKeySet signature
as asked on the dev list, I would probably be able to fix another 200~250 warning, leaving
only relevant warnings like deprecated API and such.

> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>                 Key: ADFFACES-72
>                 URL:
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Simon Lessard
>            Priority: Minor
>         Attachments:, API_template.patch, DEMO_DateField_Java_5.patch,
DEMO_java_5.patch, DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch,, SubKeyMap_Java_5.patch, TAG_Java_5.patch,,,
> This is a non critical long term improvement that should convert existing Trinidad code
to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only when calling
an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever possible to reduce
potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that returns non-generic
enabled collections

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message