From adffaces-issues-return-349-apmail-incubator-adffaces-issues-archive=incubator.apache.org@incubator.apache.org Mon Jul 17 20:18:23 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-issues-archive@locus.apache.org Received: (qmail 67123 invoked from network); 17 Jul 2006 20:18:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Jul 2006 20:18:22 -0000 Received: (qmail 25655 invoked by uid 500); 17 Jul 2006 20:18:22 -0000 Delivered-To: apmail-incubator-adffaces-issues-archive@incubator.apache.org Received: (qmail 25588 invoked by uid 500); 17 Jul 2006 20:18:22 -0000 Mailing-List: contact adffaces-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-issues@incubator.apache.org Delivered-To: mailing list adffaces-issues@incubator.apache.org Received: (qmail 25579 invoked by uid 99); 17 Jul 2006 20:18:22 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 13:18:22 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 13:18:21 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id AC7997141E8 for ; Mon, 17 Jul 2006 20:16:14 +0000 (GMT) Message-ID: <5142404.1153167374704.JavaMail.jira@brutus> Date: Mon, 17 Jul 2006 13:16:14 -0700 (PDT) From: "Adam Winer (JIRA)" To: adffaces-issues@incubator.apache.org Subject: [jira] Commented: (ADFFACES-66) Convert the existing ProcessTrainRenderer to a "faces major" version In-Reply-To: <1271747.1152921434172.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/ADFFACES-66?page=comments#action_12421711 ] Adam Winer commented on ADFFACES-66: ------------------------------------ Some smaller code review comments: - formSubmitted is obsolete; processTrain is always formSubmitted (at least for now). - More broadly speaking, you don't need _getSubmitFormName(); just use arc.getFormData().getName(); - encodeParameter() is not available in the new architecture; just delete any references to that API. Delete: public String eventKey; public String sourceKey; public String valueKey; public String sizeKey; ... and replace these with the corresponding constants. - In adf-faces-impl/src/main/resources/META-INF/faces-bean.properties, change org.apache.myfaces.adf.component.UIXProcess|org.apache.myfaces.adf.Train=org.apache.myfaces.adfinternal.uinode.nav.ProcessTrainFacesBean to: org.apache.myfaces.adf.component.UIXProcess|org.apache.myfaces.adf.Train= org.apache.myfaces.adfinternal.bean.UIXFacesBeanImpl - And delete ProcessTrainFacesBean, and the old UIX train renderer classes. > Convert the existing ProcessTrainRenderer to a "faces major" version > -------------------------------------------------------------------- > > Key: ADFFACES-66 > URL: http://issues.apache.org/jira/browse/ADFFACES-66 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Pavitra Subramaniam > Priority: Minor > Attachments: Issue66.patch > > > We really needed a Faces-major version of the ProcessTrainRenderer - that is, instead of one that is in the "org.apache.myfaces.adfinternal.ui" package, one that is in "org.apache.myfaces.adfinternal.renderkit.core.*". > This was required before we add skin selectors requsted by Simon (http://issues.apache.org/jira/browse/ADFFACES-60). > Everything in "ui" is obsolete (oooold UIX-based code), and a major technical goal of the project is to delete "ui" and "uinode" from the Apache Trinidad codebase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira