incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Commented: (ADFFACES-66) Convert the existing ProcessTrainRenderer to a "faces major" version
Date Mon, 17 Jul 2006 20:16:14 GMT
    [ http://issues.apache.org/jira/browse/ADFFACES-66?page=comments#action_12421711 ] 
            
Adam Winer commented on ADFFACES-66:
------------------------------------

Some smaller code review comments:

- formSubmitted is obsolete;  processTrain is always formSubmitted (at least for now).
- More broadly speaking, you don't need _getSubmitFormName();  just use
 arc.getFormData().getName();
- encodeParameter() is not available in the new architecture;  just delete any references
to that API.  Delete:
    public String eventKey;
    public String sourceKey;
    public String valueKey;
    public String sizeKey;
... and replace these with the corresponding constants.

- In adf-faces-impl/src/main/resources/META-INF/faces-bean.properties, change
  org.apache.myfaces.adf.component.UIXProcess|org.apache.myfaces.adf.Train=org.apache.myfaces.adfinternal.uinode.nav.ProcessTrainFacesBean
to:
org.apache.myfaces.adf.component.UIXProcess|org.apache.myfaces.adf.Train= org.apache.myfaces.adfinternal.bean.UIXFacesBeanImpl

- And delete ProcessTrainFacesBean, and the old UIX train renderer classes.

> Convert the existing ProcessTrainRenderer to a "faces major" version
> --------------------------------------------------------------------
>
>                 Key: ADFFACES-66
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-66
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>         Attachments: Issue66.patch
>
>
> We really needed a Faces-major version of the ProcessTrainRenderer - that is, instead
of one that is in the "org.apache.myfaces.adfinternal.ui" package, one that is in "org.apache.myfaces.adfinternal.renderkit.core.*".
> This was required before we add skin selectors requsted by Simon  (http://issues.apache.org/jira/browse/ADFFACES-60).

> Everything in "ui" is obsolete (oooold UIX-based code), and a major technical goal of
the project is to delete "ui" and "uinode" from the Apache Trinidad codebase.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message